field: Use `restrict` consistently in fe_sqrt #1366

pull real-or-random wants to merge 1 commits into bitcoin-core:master from real-or-random:202306-restricted-def changing 1 files +1 −1
  1. real-or-random commented at 2:48 PM on June 29, 2023: contributor

    That is, use it also in the definition and not only the declaration.

    I believe this was the intention of commit https://github.com/bitcoin-core/secp256k1/commit/be82bd8e0347e090037ff1d30a22a9d614db8c9f, but it was omitted there.

    edit: Changed the description. I'm not entirely sure but after looking at the standard, I tend to think this is more than a cosmetic change, and only this change actually makes the parameters restrict. Anyway, I believe making them restrict was simply forgotten in be82bd8e0347e090037ff1d30a22a9d614db8c9f.

  2. real-or-random added the label documentation on Jun 29, 2023
  3. field: Use `restrict` consistently in fe_sqrt
    That is, use it also in the definition and not only the declaration.

I believe this was the intention of commit
be82bd8e0347e090037ff1d30a22a9d614db8c9f, but it was omitted there.
    b79ba8aa4c
  4. real-or-random force-pushed on Jul 6, 2023
  5. real-or-random removed the label documentation on Jul 6, 2023
  6. real-or-random added the label documentation on Jul 6, 2023
  7. real-or-random added the label refactor/smell on Jul 6, 2023
  8. real-or-random removed the label documentation on Jul 6, 2023
  9. sipa commented at 12:08 AM on July 9, 2023: contributor

    utACK b79ba8aa4c074b2cd09188f6f85ba68d6b80fe50

  10. real-or-random merged this on Jul 11, 2023
  11. real-or-random closed this on Jul 11, 2023
  12. real-or-random commented at 11:15 PM on July 11, 2023: contributor

    I double-checked all the call sites manually, and we check aliasing in VERIFY mode, so I think it's safe to merge this.

  13. fanquake referenced this in commit 56c05c5ec4 on Jul 17, 2023
  14. fanquake referenced this in commit ff061fde18 on Jul 18, 2023
  15. hebasto referenced this in commit 270d2b37b8 on Jul 21, 2023
  16. delta1 referenced this in commit 3f32c20932 on Aug 8, 2023
  17. delta1 referenced this in commit 31ac0c1081 on Aug 31, 2023
  18. janus referenced this in commit 476a2176e7 on Sep 11, 2023
  19. div72 referenced this in commit af627d47c3 on Apr 12, 2025
  20. str4d referenced this in commit 3b49801869 on Jun 4, 2025
Contributors
real-or-randomsipa
Labels
tweak/refactor
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:52 UTC