This PR fixes tests for Windows binaries using Wine:
$ cmake -S . -B ../mingw -DCMAKE_TOOLCHAIN_FILE=cmake/x86_64-w64-mingw32.toolchain.cmake
$ cmake --build ../mingw
$ cmake --build ../mingw -t check
Test project /home/hebasto/git/secp256k1/mingw
Start 1: noverify_tests
Could not find executable noverify_tests
...
An executable target in the `COMMAND` option will automatically be
replaced by the location of the executable created at build time.
This change fixes tests for Windows binaries using Wine.
Concept ACK
Mostly because I'm curious: Do you know why this fixes tests? After reading the docs in https://cmake.org/cmake/help/latest/command/add_test.html, I don't see how the full syntax should make a difference here.
Nevermind, I found it:
Unlike the above NAME signature, target names are not supported in the command-line.
402 | @@ -403,7 +403,7 @@ task: 403 | - cmake --build build --config RelWithDebInfo -- -property:UseMultiToolTask=true;CL_MPcount=5 404 | check_script: 405 | - '%x64_NATIVE_TOOLS%' 406 | - - ctest --test-dir build -j 5 407 | + - ctest -C RelWithDebInfo --test-dir build -j 5
Is this change necessary? Shouldn't that be the default already?
Is this change necessary?
It is.
Shouldn't that be the default already?
Otherwise, for multi-config generators, ctest complains:
Test not available without configuration. (Missing "-C <config>"?)
ACK 755629bc032af155ff68fa820244d04cb80547c5