tests: remove extra semicolon in macro #1286

pull jonasnick wants to merge 2 commits into bitcoin-core:master from jonasnick:tests-semicolon changing 2 files +20 −19
  1. jonasnick commented at 8:22 PM on April 21, 2023: contributor

    No description provided.

  2. tests: remove extra semicolon in macro 3858bad2c6
  3. hebasto commented at 8:56 PM on April 21, 2023: member

    Where the PRINT_BUF macro is used?

  4. jonasnick commented at 7:31 AM on April 23, 2023: contributor

    @hebasto it was just added with #1205 and not used anywhere as it's intended for development and debugging (see #1205 (comment) for the rationale).

  5. real-or-random commented at 10:16 AM on April 25, 2023: contributor

    Now I also realized that the current location of the macro and the function are not great because you can use them only in tests.c but not in the actual library... Sorry for that. @jonasnick Can you move the macro and the function? I propose to move it to the top of util.h, which is included very early. This should do the trick.

  6. debug: move helper for printing buffers into util.h c4062d6b5d
  7. jonasnick commented at 4:08 PM on April 25, 2023: contributor

    @real-or-random good point. Moved to util.h.

  8. real-or-random approved
  9. real-or-random commented at 4:14 PM on April 25, 2023: contributor

    utACK c4062d6b5d83572c1932f32003a7c0e901fffc23

  10. hebasto approved
  11. hebasto commented at 9:07 PM on April 25, 2023: member

    ACK c4062d6b5d83572c1932f32003a7c0e901fffc23, I have reviewed the code and it looks OK.

  12. real-or-random merged this on Apr 25, 2023
  13. real-or-random closed this on Apr 25, 2023
  14. sipa referenced this in commit b4eb644b6c on May 12, 2023
  15. hebasto referenced this in commit 49c52ea2b1 on May 13, 2023
  16. vmta referenced this in commit e1120c94a1 on Jun 4, 2023
  17. sipa referenced this in commit 901336eee7 on Jun 21, 2023
  18. vmta referenced this in commit 8f03457eed on Jul 1, 2023
  19. delta1 referenced this in commit 3f32c20932 on Aug 8, 2023
  20. delta1 referenced this in commit 31ac0c1081 on Aug 31, 2023
  21. janus referenced this in commit c4348d88db on Sep 11, 2023
  22. div72 referenced this in commit af627d47c3 on Apr 12, 2025
  23. str4d referenced this in commit 5a6bf5f178 on Jun 4, 2025
  24. Fabcien referenced this in commit 27e3500c7c on Apr 20, 2026
  25. Fabcien referenced this in commit d6579f5780 on Apr 20, 2026
Contributors
jonasnickhebastoreal-or-random
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:52 UTC