Remove bits argument from secp256k1_wnaf_const{_xonly} #1265

pull sipa wants to merge 1 commits into bitcoin-core:master from sipa:202304_noecmultconstbits changing 6 files +43 −63
  1. sipa commented at 10:57 AM on April 10, 2023: contributor

    There is little reason for having the number of bits in the scalar as a parameter, as I don't think there are any (current) use cases for non-256-bit scalars.

  2. Remove bits argument from secp256k1_wnaf_const (always 256) a575339c02
  3. real-or-random commented at 11:14 AM on April 10, 2023: contributor

    Concept ACK

    I don't think there are any (current) use cases for non-256-bit scalars.

    Indeed, it seems unlikely that we'll ever have non-256-bit private scalars.

  4. jonasnick approved
  5. jonasnick commented at 8:34 AM on April 18, 2023: contributor

    ACK a575339c0282ba49a4f46c9c660a4cc3b6bfc703

  6. real-or-random approved
  7. real-or-random commented at 10:15 AM on April 18, 2023: contributor

    utACK a575339c0282ba49a4f46c9c660a4cc3b6bfc703

  8. real-or-random merged this on Apr 18, 2023
  9. real-or-random closed this on Apr 18, 2023

  10. sipa referenced this in commit b4eb644b6c on May 12, 2023
  11. hebasto referenced this in commit 49c52ea2b1 on May 13, 2023
  12. vmta referenced this in commit e1120c94a1 on Jun 4, 2023
  13. sipa referenced this in commit 901336eee7 on Jun 21, 2023
  14. vmta referenced this in commit 8f03457eed on Jul 1, 2023
  15. delta1 referenced this in commit 3f32c20932 on Aug 8, 2023
  16. delta1 referenced this in commit 31ac0c1081 on Aug 31, 2023
  17. janus referenced this in commit c4348d88db on Sep 11, 2023
  18. div72 referenced this in commit af627d47c3 on Apr 12, 2025
  19. str4d referenced this in commit 5a6bf5f178 on Jun 4, 2025
  20. Fabcien referenced this in commit ee9705f830 on Apr 17, 2026
  21. Fabcien referenced this in commit a7a17a36cf on Apr 17, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:52 UTC