Apply Checks only in VERIFY mode. #1247

pull roconnor-blockstream wants to merge 1 commits into bitcoin-core:master from roconnor-blockstream:patch-5 changing 1 files +4 −0
  1. roconnor-blockstream commented at 2:07 AM on March 23, 2023: contributor

    This is already done in field_5x52_impl.h.

  2. Apply Checks only in VERIFY mode. 4ebd82852d
  3. jonasnick commented at 8:39 AM on March 23, 2023: contributor

    If the goal is to make the two files consistent, wouldn't it be better to remove the ifdef from field_5x52_impl.h (EDIT: because we generally don't wrap simple VERIFY_CHECKs in VERIFY ifdefs)?

  4. roconnor-blockstream commented at 12:29 PM on March 23, 2023: contributor

    We generally do wrap non-trivial VERIFY_CHECKs, particularly when they call functions.

  5. jonasnick commented at 3:58 PM on March 23, 2023: contributor

    You're right.

    ACK 4ebd82852d3ad00ab579b26173575a4f4642ea76

  6. roconnor-blockstream commented at 6:21 PM on March 23, 2023: contributor

    I do admit, with so many exceptions, the whole idea of enabling VERIY_CHECKs in release builds feels of questionable value.

  7. sipa commented at 1:21 PM on March 24, 2023: contributor

    ACK 4ebd82852d3ad00ab579b26173575a4f4642ea76

  8. sipa merged this on Mar 24, 2023
  9. sipa closed this on Mar 24, 2023
  10. roconnor-blockstream deleted the branch on Mar 24, 2023
  11. roconnor-blockstream referenced this in commit 1a7dfb9299 on Mar 24, 2023
  12. roconnor-blockstream referenced this in commit 898381f87c on Mar 24, 2023
  13. sipa referenced this in commit e1552d578e on Apr 11, 2023
  14. sipa referenced this in commit c981671e9b on Apr 14, 2023
  15. apoelstra referenced this in commit 0849ab161c on Apr 28, 2023
  16. hebasto referenced this in commit 49c52ea2b1 on May 13, 2023
  17. RandyMcMillan referenced this in commit 3cc75121b3 on May 27, 2023
  18. vmta referenced this in commit e1120c94a1 on Jun 4, 2023
  19. vmta referenced this in commit 8f03457eed on Jul 1, 2023
  20. delta1 referenced this in commit 3f32c20932 on Aug 8, 2023
  21. delta1 referenced this in commit 31ac0c1081 on Aug 31, 2023
  22. janus referenced this in commit 05145db5ff on Sep 3, 2023
  23. backpacker69 referenced this in commit e66b1bd882 on Mar 5, 2024
  24. div72 referenced this in commit af627d47c3 on Apr 12, 2025
  25. str4d referenced this in commit f634fc6004 on Jun 4, 2025
  26. eth-ravenxcb54 referenced this in commit 0147d7ab43 on Sep 29, 2025
  27. Fabcien referenced this in commit 4f4541d514 on Apr 16, 2026
  28. Fabcien referenced this in commit f6b81615cd on Apr 16, 2026
Contributors
roconnor-blockstreamjonasnicksipa
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:52 UTC