This PR:
- drops tinkering with the
COMPILE_OPTIONSdirectory property intry_add_compile_option()and renames it totry_append_cflags() - copies related comments from
configure.ac
cmake: Improve and document compiler flag checks #1240
pull hebasto wants to merge 3 commits into bitcoin-core:master from hebasto:230312-check changing 3 files +43 −40-
hebasto commented at 11:17 PM on March 12, 2023: member
- hebasto force-pushed on Mar 22, 2023
- real-or-random approved
-
real-or-random commented at 8:36 AM on March 26, 2023: contributor
ACK 93f2ba0a4f7e576441eb5feb17e4cb3d178d37a3
- hebasto force-pushed on Apr 27, 2023
-
hebasto commented at 11:58 AM on April 27, 2023: member
Rebased.
-
19516ed3e9
cmake: Use `add_compile_options()` in `try_add_compile_option()`
This change drops tinkering with the `COMPILE_OPTIONS` directory property. Also `try_add_compile_option()` can handle a list of flags now, if they are required to be checked simultaneously. An explanatory comments have been added as well.
-
6ece1507cb
cmake, refactor: Rename `try_add_compile_option` to `try_append_cflags`
Actually, `try_append_cflags()` can handle a list of flags, and the new name is similar to the one used in `configure.ac`.
-
cmake, doc: Document compiler flags a8d059f76c
- hebasto force-pushed on Apr 27, 2023
-
theuni commented at 1:46 PM on April 27, 2023: contributor
- real-or-random merged this on Apr 27, 2023
- real-or-random closed this on Apr 27, 2023
- hebasto deleted the branch on Apr 28, 2023
- sipa referenced this in commit b4eb644b6c on May 12, 2023
- hebasto referenced this in commit 49c52ea2b1 on May 13, 2023
- vmta referenced this in commit e1120c94a1 on Jun 4, 2023
- sipa referenced this in commit 901336eee7 on Jun 21, 2023
- vmta referenced this in commit 8f03457eed on Jul 1, 2023
- delta1 referenced this in commit 3f32c20932 on Aug 8, 2023
- delta1 referenced this in commit 31ac0c1081 on Aug 31, 2023
- janus referenced this in commit c4348d88db on Sep 11, 2023
- div72 referenced this in commit af627d47c3 on Apr 12, 2025
- str4d referenced this in commit 5a6bf5f178 on Jun 4, 2025
Contributors