cmake: Rename project to "libsecp256k1" #1229

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:230308-cmake changing 3 files +18 −18

hebasto commented at 9:22 PM on March 8, 2023: member

Was discussed today on IRC.
cmake: Rename project to "libsecp256k1" 8be82d4362
in examples/CMakeLists.txt:12 in 8be82d4362
```
   8 | @@ -9,9 +9,9 @@ target_link_libraries(example INTERFACE
   9 |    $<$<PLATFORM_ID:Windows>:bcrypt>
  10 |  )
  11 |  if(SECP256K1_BUILD_SHARED)
  12 | -  target_link_libraries(example INTERFACE ${PROJECT_NAME})
  13 | +  target_link_libraries(example INTERFACE secp256k1)
```
sipa commented at 9:31 PM on March 8, 2023:

I'd change these too, to libsecp256k1 and libsecp256k1_static.

real-or-random commented at 9:35 PM on March 8, 2023:

I'd change these too, to libsecp256k1 and libsecp256k1_static.

Does this actually work?

real-or-random commented at 9:48 PM on March 8, 2023:

No, we need to keep it like this. We could improve this after the release by defining a variable by taking a substring of PROJECT_NAME.
real-or-random approved
real-or-random commented at 9:47 PM on March 8, 2023: contributor

ACK 8be82d43628138553bc126a76d52edf523031792
sipa commented at 9:56 PM on March 8, 2023: contributor

ACK 8be82d43628138553bc126a76d52edf523031792
sipa merged this on Mar 8, 2023
sipa closed this on Mar 8, 2023
hebasto deleted the branch on Mar 8, 2023
sipa referenced this in commit 763079a3f1 on Mar 8, 2023
div72 referenced this in commit 945b094575 on Mar 14, 2023
vmta referenced this in commit e1120c94a1 on Jun 4, 2023
vmta referenced this in commit 8f03457eed on Jul 1, 2023
delta1 referenced this in commit 3f32c20932 on Aug 8, 2023
delta1 referenced this in commit 31ac0c1081 on Aug 31, 2023
janus referenced this in commit 4816e2a921 on Sep 3, 2023
backpacker69 referenced this in commit 26f6d832fb on Mar 5, 2024
str4d referenced this in commit b350ac56ac on Jun 4, 2025

Contributors

hebasto

sipa

real-or-random

Linked (view graph)

#1235 build: Meta-issue for follow-ups to initial CMake merge (#1113)