No description provided.
Make all non-API functions (except main) static #1190
pull sipa wants to merge 1 commits into bitcoin-core:master from sipa:202301_static_tests changing 15 files +230 −233-
sipa commented at 5:03 PM on January 9, 2023: contributor
-
Make all non-API functions (except main) static e03ef86559
-
real-or-random commented at 5:20 PM on January 9, 2023: contributor
Totally not opposed to this but do we really care about this in bench/tests? And if yes, do you see any way to ensure we don't miss functions (in the future)?
-
sipa commented at 6:07 PM on January 9, 2023: contributor
Totally not opposed to this but do we really care about this in bench/tests?
I don't think we care either way for these, but it's nice to be consistent.
And if yes, do you see any way to ensure we don't miss functions (in the future)?
We don't currently ensure this anywhere, but with a change like this, approaches like #1135 (depending on the direction it goes in) may be extensible to tests/bench?
- real-or-random approved
-
real-or-random commented at 6:14 PM on January 9, 2023: contributor
Okay, agreed on both counts.
utACK e03ef8655933d3e2b4830e7f8fe86deba820a073
- hebasto approved
-
hebasto commented at 6:43 PM on January 13, 2023: member
ACK e03ef8655933d3e2b4830e7f8fe86deba820a073.
On my Ubuntu 22.04 (x86_64), the resulted test and bench binaries are a bit smaller in size, except for the
bench_internal, which is a bit larger. - real-or-random merged this on Jan 16, 2023
- real-or-random closed this on Jan 16, 2023
-
real-or-random commented at 5:54 PM on January 16, 2023: contributor
(Fwiw, github indicated a merge conflict here (due to the renamed
src/cttime_tests.c) but my local git auto-merged this cleanly without conflicts, and the merge results looks clean...) - dhruv referenced this in commit 4d33046ce3 on Feb 1, 2023
- dhruv referenced this in commit 55e7f2cf2b on Feb 2, 2023
- stratospher referenced this in commit 647f63669e on Feb 6, 2023
- dhruv referenced this in commit a4351c0df6 on Feb 20, 2023
- stratospher referenced this in commit 23f825fc8b on Feb 21, 2023
- hebasto referenced this in commit 7c0cc5d976 on Mar 7, 2023
- dhruv referenced this in commit a5df79db12 on Mar 7, 2023
- dhruv referenced this in commit 77b510d84c on Mar 7, 2023
- sipa referenced this in commit 763079a3f1 on Mar 8, 2023
- div72 referenced this in commit 945b094575 on Mar 14, 2023
- vmta referenced this in commit e1120c94a1 on Jun 4, 2023
- vmta referenced this in commit 8f03457eed on Jul 1, 2023
- delta1 referenced this in commit 3f32c20932 on Aug 8, 2023
- delta1 referenced this in commit 31ac0c1081 on Aug 31, 2023
- janus referenced this in commit 4816e2a921 on Sep 3, 2023
- backpacker69 referenced this in commit 26f6d832fb on Mar 5, 2024
- str4d referenced this in commit b350ac56ac on Jun 4, 2025
- Fabcien referenced this in commit 9279020dd2 on Apr 8, 2026
- Fabcien referenced this in commit fc1198cb51 on Apr 8, 2026
Contributors
Linked (view graph)