This upgrades the macOS image from Catalina to Ventura, which also means it's switching from x86_64 to arm64 (addressing #1151).
It drops valgrind and the ctime tests on macOS, as valgrind simply isn't supported anymore there. We may recover some of that functionality by adding MSan (#1155) for memory-checking there, and adding ctime-using-mtime (TODO).
120 | HOMEBREW_NO_AUTO_UPDATE: 1 121 | HOMEBREW_NO_INSTALL_CLEANUP: 1 122 | - # Cirrus gives us a fixed number of 12 virtual CPUs. Not that we even have that many jobs at the moment... 123 | - MAKEFLAGS: -j13 124 | + # Cirrus gives us a fixed number of 4 virtual CPUs. Not that we even have that many jobs at the moment... 125 | + MAKEFLAGS: -j4
MAKEFLAGS: -j5
maybe that's even better :shrug: but I don't know.
Done.
Concept ACK
Sad that we have to give up on valgrind but this was foreseeable. There's really not much we can do as long as recent version don't support MacOS.
It may be interesting to have MSan as an alternative, both for normal memory issues but also for constant-time tests, see https://www.amongbytes.com/post/20210709-testing-constant-time/ . Its guarantees are somewhat weaker than valgrind (e.g., it does not run on the actual uninstrumented binary) but if it's supported on more platforms, that will be helpful.
Also Cirrus supports running on AWS Graviton (native ARM) now. We can probably get some of our ARM64 testing done there (including valgrind).
Also Cirrus supports running on AWS Graviton (native ARM) now. We can probably get some of our ARM64 testing done there (including valgrind).
see #1153
ACK a8494b02bfe7578ffb76e66924e76c83556a802d
ACK a8494b02bfe7578ffb76e66924e76c83556a802d