build: Add a check that Valgrind actually supports a host platform #1027

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:211203-riscv changing 1 files +7 −1

hebasto commented at 1:21 PM on December 3, 2021: member

This PR adds a check that Valgrind actually supports a host platform.

On master (49f608de474a89e5c742830c8ff5ac8978b5796a):

$ ./autogen.sh &> /dev/null && ./configure -q --host=riscv64-linux-gnu 2>&1 | grep valgrind
  valgrind                = yes

With this PR:

$ ./autogen.sh &> /dev/null && ./configure -q --host=riscv64-linux-gnu 2>&1 | grep valgrind
  valgrind                = no

Closes #1023.

real-or-random commented at 2:00 PM on December 3, 2021: contributor

Nice, I thought that will be much more diffcult.

Concept ACK

nit: s/valgring/valgrind
hebasto renamed this:
~~build: Add a check that Valgring actually supports a host platform~~
build: Add a check that Valgrind actually supports a host platform
on Dec 3, 2021
build: Add a check that Valgrind actually supports a host platform 7c7ce872a5
hebasto force-pushed on Dec 3, 2021
hebasto commented at 3:34 PM on December 3, 2021: member

@real-or-random

nit: s/valgring/valgrind

Thanks! Fixed.
sipa commented at 10:36 PM on December 3, 2021: contributor

utACK 7c7ce872a53f386f7c6a3a8ea04442840902193b
real-or-random commented at 10:34 AM on December 5, 2021: contributor

utACK 7c7ce872a53f386f7c6a3a8ea04442840902193b

valgrind.h (included by memcheck.h) defines NVALGRIND if platform detection fails: https://sourceware.org/git/?p=valgrind.git;a=blob;f=include/valgrind.h.in;h=aa0b431256e14da602064c1052c2c5fb5f7f88d4;hb=HEAD#l172

edit: I checked that valgrind support still is detected on my machine.
real-or-random merged this on Dec 5, 2021
real-or-random closed this on Dec 5, 2021
hebasto deleted the branch on Dec 5, 2021
sipa referenced this in commit 86dbc4d075 on Dec 15, 2021
real-or-random referenced this in commit 21e2d65b79 on Jan 5, 2022
gwillen referenced this in commit 35d6112a72 on May 25, 2022
janus referenced this in commit 879a9a27b9 on Jul 10, 2022
patricklodder referenced this in commit 21badcf9d2 on Jul 25, 2022
patricklodder referenced this in commit 03002a9013 on Jul 28, 2022
backpacker69 referenced this in commit 77186f4a04 on Jan 18, 2023
real-or-random referenced this in commit 2e035af251 on Apr 20, 2023
str4d referenced this in commit 6de4698bf9 on Apr 21, 2023
vmta referenced this in commit e1120c94a1 on Jun 4, 2023
vmta referenced this in commit 8f03457eed on Jul 1, 2023
Fabcien referenced this in commit 0a19a03a6d on Jan 28, 2026
Fabcien referenced this in commit 4d048a879b on Jan 28, 2026

Contributors

hebasto

real-or-random

sipa

Linked (view graph)

#1023 -Wunused-parameter warnings when cross-compiling for riscv64-linux-gnu #1273 build: Make `SECP_VALGRIND_CHECK` preserve `CPPFLAGS`