Show permissions instead of whitelisted #34

pull laanwj wants to merge 1 commits into bitcoin-core:master from laanwj:2020_07_gui_permissions changing 2 files +11 −3

laanwj commented at 8:56 PM on July 15, 2020: member

Show detailed permissions instead of legacy "whitelisted" flag in the peer list details. These are formatted with & in between just like services flags. It reuses the "N/A" translation message if there are no special permissions. This removes the one-but-last use of legacyWhitelisted.

gui: Show permissions instead of whitelisted

Show detailed permissions instead of legacy "whitelisted" flag.
These are formatted with `&` in between just like services flags.
It reuses the "N/A" translation message if not.
This removes the one-but-last use of `legacyWhitelisted`.

784ef8be41

hebasto commented at 9:23 PM on July 15, 2020: member

Concept ACK.
maflcko commented at 6:03 AM on July 16, 2020: contributor

Tested aCK
maflcko renamed this:
~~gui: Show permissions instead of whitelisted~~
Show permissions instead of whitelisted
on Jul 16, 2020
maflcko merged this on Jul 16, 2020
maflcko closed this on Jul 16, 2020
jonatack commented at 8:06 AM on July 16, 2020: member

post-merge ACK 784ef8be41c7e5130a6b063b359031ee1ce75aff

in src/qt/rpcconsole.cpp:1123 in 784ef8be41

1119 | @@ -1120,7 +1120,15 @@ void RPCConsole::updateNodeDetail(const CNodeCombinedStats *stats)
1120 |      ui->peerSubversion->setText(QString::fromStdString(stats->nodeStats.cleanSubVer));
1121 |      ui->peerDirection->setText(stats->nodeStats.fInbound ? tr("Inbound") : tr("Outbound"));
1122 |      ui->peerHeight->setText(QString::number(stats->nodeStats.nStartingHeight));
1123 | -    ui->peerWhitelisted->setText(stats->nodeStats.m_legacyWhitelisted ? tr("Yes") : tr("No"));

promag commented at 9:15 AM on July 16, 2020:

Why wasn't m_legacyWhitelisted removed?

maflcko commented at 11:01 AM on July 16, 2020:

See OP

This removes the one-but-last use of legacyWhitelisted.

promag commented at 12:11 PM on July 16, 2020:

Oh right, miss interpreted "one-but-last", sorry.

amitiuttarwar commented at 6:46 AM on December 24, 2020:

done in https://github.com/bitcoin/bitcoin/pull/20755 :)

in src/qt/rpcconsole.cpp:1123 in 784ef8be41

1119 | @@ -1120,7 +1120,15 @@ void RPCConsole::updateNodeDetail(const CNodeCombinedStats *stats)
1120 |      ui->peerSubversion->setText(QString::fromStdString(stats->nodeStats.cleanSubVer));
1121 |      ui->peerDirection->setText(stats->nodeStats.fInbound ? tr("Inbound") : tr("Outbound"));
1122 |      ui->peerHeight->setText(QString::number(stats->nodeStats.nStartingHeight));
1123 | -    ui->peerWhitelisted->setText(stats->nodeStats.m_legacyWhitelisted ? tr("Yes") : tr("No"));
1124 | +    if (stats->nodeStats.m_permissionFlags == PF_NONE) {

promag commented at 9:15 AM on July 16, 2020:

nit, could #include <net_permissions.h>.

promag commented at 9:17 AM on July 16, 2020: contributor

Code review ACK 784ef8be41c7e5130a6b063b359031ee1ce75aff.
Sjors commented at 10:24 AM on July 16, 2020: member

Post merge concept ACK, nice!
sidhujag referenced this in commit 06e3e0c10e on Jul 18, 2020
apoelstra referenced this in commit a70cb0fa02 on Dec 3, 2020
gwillen referenced this in commit 6d69f4d2cc on Mar 19, 2021
Fabcien referenced this in commit 158c273c4a on Sep 1, 2021
bitcoin-core locked this on Feb 15, 2022

Contributors

Linked (view graph)

#7 Crash on exit #796 ci_native_asan: UndefinedBehaviorSanitizer: null-pointer-use qt/test/wallettests.cpp:424:25 in