No description provided.
Avoid VLA in hash.h #9791
pull sipa wants to merge 1 commits into bitcoin:master from sipa:novla changing 1 files +4 −4-
sipa commented at 11:29 PM on February 17, 2017: member
-
Avoid VLA in hash.h 5c8fd50811
- gmaxwell approved
-
gmaxwell commented at 11:46 PM on February 17, 2017: contributor
utACK.
- fanquake added the label Validation on Feb 18, 2017
-
paveljanik commented at 7:23 AM on February 18, 2017: contributor
Compiles and works together with #9789.
ACK https://github.com/bitcoin/bitcoin/pull/9791/commits/5c8fd508112016c3821b71112270afe83e6949ac
-
laanwj commented at 9:40 AM on February 18, 2017: member
-
sipa commented at 9:47 AM on February 18, 2017: member
To clarify: my GCC does not consider this to be a VLA, but at least some Clang versions do.
-
laanwj commented at 10:00 AM on February 18, 2017: member
Well I think this makes the code clearer too, so it's a win in any case.
-
MarcoFalke commented at 10:28 AM on February 18, 2017: member
5c8fd508112016c3821b71112270afe83e6949ac gives same binaries with recent gcc on my arch.
utACK 5c8fd508112016c3821b71112270afe83e6949ac
- laanwj merged this on Feb 19, 2017
- laanwj closed this on Feb 19, 2017
- laanwj referenced this in commit 1f9e904f45 on Feb 19, 2017
- laanwj referenced this in commit 1825a03f81 on Feb 28, 2017
- codablock referenced this in commit 16b2a1d1b9 on Jan 26, 2018
- dagurval cross-referenced this on Apr 25, 2018 from issue Introduce CHashVerifier + specialization of SipHash for 256 + 32 bit data by dagurval
- sickpig cross-referenced this on Jun 20, 2018 from issue [PORT] threat warning on VLA as error if `--enable-werror` is specifed by sickpig
- andvgal referenced this in commit 334bf259f3 on Jan 6, 2019
- CryptoCentric referenced this in commit 3a11138451 on Feb 27, 2019
- bitcoin locked this on Sep 8, 2021
Contributors
Labels