netbase: Do not print an error on connection timeouts through proxy #9726

pull laanwj wants to merge 2 commits into bitcoin:master from laanwj:2017_02_intr_recv_error changing 1 files +34 −18

laanwj commented at 8:00 AM on February 9, 2017: member
If a timeout happens while reading the proxy response, this effectively means we timed out while connecting to the remote node. This is very common for Tor, so do not print an error message to the log in that case.

Avoids a flood of
```
2017-02-09 07:10:02 ERROR: Error reading proxy response
```
while running through Tor, causing users to blame the proxy.

Ref: #9430.
netbase: Make InterruptibleRecv return an error code instead of bool 13f608582c

netbase: Do not print an error on connection timeouts through proxy

If a timeout happens while reading the proxy response, this effectively
means we timed out while connecting to the remote node. This is very
common for Tor, so do not print an error message.

3ddfe29837

laanwj added the label P2P on Feb 9, 2017
laanwj cross-referenced this on Feb 9, 2017 from issue 'ERROR: Error reading proxy response' when using TOR on bitcoind by ghost
gmaxwell approved
gmaxwell commented at 4:42 PM on February 9, 2017: contributor

utACK
laanwj merged this on Feb 20, 2017
laanwj closed this on Feb 20, 2017
laanwj referenced this in commit 7639d38f14 on Feb 20, 2017
str4d cross-referenced this on Mar 24, 2017 from issue Tor ephemeral hidden services by str4d
PastaPastaPasta referenced this in commit 1c57a5d050 on Dec 28, 2018
PastaPastaPasta referenced this in commit 28c9348ae7 on Dec 29, 2018
PastaPastaPasta referenced this in commit f2fd4b7b56 on Dec 29, 2018
UdjinM6 referenced this in commit a49f4123e5 on Jan 3, 2019
CryptoCentric referenced this in commit c632f583ae on Jul 11, 2019
furszy cross-referenced this on Mar 25, 2020 from issue netbase: Do not print an error on connection timeouts through proxy by furszy
furszy referenced this in commit 18fa545831 on Mar 26, 2020
akshaynexus referenced this in commit 3974840e8f on Mar 30, 2020
wqking referenced this in commit f52d7b2d27 on Aug 24, 2020
DemonRx cross-referenced this on Feb 24, 2021 from issue DNS Seeders unreachable when using proxy through Tor connections by DemonRx
DemonRx cross-referenced this on Feb 24, 2021 from issue [netbase] Do not print an error on connection timeouts through proxy by DemonRx
bitcoin locked this on Sep 8, 2021

Contributors

laanwj

gmaxwell

Labels

P2P

Linked (view graph)

#9430 'ERROR: Error reading proxy response' when using TOR on bitcoind