Remove unused variables #9532

pull practicalswift wants to merge 2 commits into bitcoin:master from practicalswift:remove-unused-variables changing 8 files +2 −11

practicalswift commented at 5:38 PM on January 12, 2017: contributor

No description provided.
practicalswift force-pushed on Jan 12, 2017
MarcoFalke cross-referenced this on Jan 12, 2017 from issue [trivial] Remove unused int64_t nSinceLastSeen by practicalswift
practicalswift force-pushed on Jan 12, 2017
fanquake added the label Refactoring on Jan 12, 2017
fanquake renamed this:
~~[trivial] Remove unused variables~~
Remove unused variables
on Jan 12, 2017
fanquake commented at 10:10 PM on January 12, 2017: member

Can you please rename the commits to remove the [trivial], as that tag is really only used when a PR doesn't touch any code.
jtimon commented at 11:17 PM on January 12, 2017: contributor

I have used "Trivial: " in the beginning of the message of some commits that changed code in trivial ways, I didn't know that policy. When I don't touch code at all I tend to just use "Doc: ", but I did these things on my own, if we have a place describing these kind of best practices I missed it, can you link to it?
jtimon commented at 1:34 AM on January 13, 2017: contributor

ACK 180df23
in src/addrman.cpp:None in 180df23e20 outdated
```
  53 | @@ -54,11 +54,8 @@ double CAddrInfo::GetChance(int64_t nNow) const
  54 |  {
  55 |      double fChance = 1.0;
  56 |  
  57 | -    int64_t nSinceLastSeen = nNow - nTime;
  58 |      int64_t nSinceLastTry = nNow - nLastTry;
```
robmcl4 commented at 3:59 AM on January 13, 2017:

Maybe initializing nSinceLastTry and the following if statement can be collapsed into a call to std::max().

practicalswift commented at 9:27 AM on January 13, 2017:

Good idea! I'll take that in another PR!

practicalswift commented at 3:25 PM on January 18, 2017:

@robmcl4 Submitted as #9553 :-)
dcousens approved
paveljanik commented at 9:21 AM on January 13, 2017: contributor

ACK https://github.com/bitcoin/bitcoin/pull/9532/commits/180df23e2006e075f46a1048f29598a3c44f93b7
Remove unused Python variables ac4a095306
Remove unused int64_t nSinceLastSeen 90fd29bd0d
practicalswift force-pushed on Jan 13, 2017
practicalswift commented at 5:57 PM on January 13, 2017: contributor

@fanquake Removed [trivial] from the commit titles as requested :-)
practicalswift cross-referenced this on Jan 14, 2017 from issue Use z = std::max(x - y, 0) instead of z = x - y; if (z < 0) z = 0; by practicalswift
instagibbs commented at 2:18 PM on January 14, 2017: member

@jtimon #9542 PR about [trivial] tag
practicalswift cross-referenced this on Jan 18, 2017 from issue Remove unused Python imports by practicalswift
practicalswift cross-referenced this on Jan 18, 2017 from issue 6696b46: Clang Static Analyzer Report by kallewoof
practicalswift commented at 4:53 PM on January 29, 2017: contributor

I believe this one should be ready to merge. Please let me know if any adjustments are needed and I'll fix it right away! :-)
jtimon commented at 10:23 PM on February 2, 2017: contributor

utACK 90fd29b
practicalswift commented at 10:23 PM on February 2, 2017: contributor

Any sponsor who has time to take a look at this hopefully trivial PR? :-)
MarcoFalke commented at 12:10 AM on February 3, 2017: member

utACK 90fd29bd0dcbaf5d5c4ef9e69824297c35f0b88e
laanwj merged this on Feb 7, 2017
laanwj closed this on Feb 7, 2017
laanwj referenced this in commit b709fe7ffc on Feb 7, 2017
codablock referenced this in commit 027fbcdb0b on Jan 19, 2018
codablock referenced this in commit 767f5e436b on Jan 23, 2018
andvgal referenced this in commit 8a1c7eae79 on Jan 6, 2019
CryptoCentric referenced this in commit da224e566e on Feb 27, 2019
practicalswift deleted the branch on Apr 10, 2021
bitcoin locked this on Aug 16, 2022