JeremyRubin
commented at 1:15 AM on January 6, 2017:
contributor
Previously, I duplicated the SignatureCacheHasher in the cuckoocache tests to avoid extra changes/review in the cuckoocache pr. This moves the SignatureCacheHasher to the sigcache header, out of the anonymous namespace, so that the tests can import it.
Not very critical, but it is good to make sure that these implementations don't ever diverge by only having this class defined once.
fanquake added the label Refactoring on Jan 6, 2017
MarcoFalke
commented at 1:20 AM on January 6, 2017:
member
Everyone-loves-negative-net-diffs ACK0b829c0
dcousens approved
NicolasDorier
commented at 6:22 AM on January 6, 2017:
contributor
utACK0b829c0
paveljanik
commented at 10:28 AM on January 6, 2017:
contributor
TheBlueMatt
commented at 4:45 PM on April 12, 2017:
contributor
Needs rebase.
JeremyRubin force-pushed on Apr 12, 2017
JeremyRubin
commented at 5:07 PM on April 12, 2017:
contributor
rebased
TheBlueMatt
commented at 5:26 PM on April 12, 2017:
contributor
Please add an extra line between the commit title and the commit message, for some reason git likes to think that its all intended as a multi-line-super-long title if you dont.
Deduplicate SignatureCacheHasher
This moves the SignatureCacheHasher to the sigcache header, out of the anonymous
namespace, so that the tests can import it.
f9c88079df
JeremyRubin force-pushed on Apr 12, 2017
JeremyRubin
commented at 9:44 PM on April 12, 2017:
contributor
@TheBlueMatt I think that's a local issue in your git client settings, I can't reproduce it. Nonetheless, I inserted an additional newline.
sipa merged this on Apr 13, 2017
sipa closed this on Apr 13, 2017
sipa referenced this in commit b7365f0545 on Apr 13, 2017
jtimon
commented at 4:14 PM on April 18, 2017:
contributor
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC