Prevent stuck block download in large reorganisations #948

pull sipa wants to merge 1 commits into bitcoin:master from sipa:unstuck changing 1 files +8 −3
  1. sipa commented at 10:52 PM on March 18, 2012: member

    In cases of very large reorganisations (hundreds of blocks), a situation may appear where an 'inv' is sent as response to a 'getblocks', but the last block mentioned in the inv is already known to the receiver node. However, the supplying node uses a request for this last block as a trigger to send the rest of the inv blocks. If it never comes, the block chain download is stuck.

    This pull request makes the receiver node always request the last inv'ed block, even if it is already known, to prevent this problem.

  2. TheBlueMatt commented at 2:49 AM on March 19, 2012: contributor

    ACK for 0.6

  3. gavinandresen commented at 2:31 PM on March 19, 2012: contributor

    ACK

  4. Prevent stuck block download in large reorganisations
    In cases of very large reorganisations (hundreds of blocks), a situation
    may appear where an 'inv' is sent as response to a 'getblocks', but the
    last block mentioned in the inv is already known to the receiver node.
    However, the supplying node uses a request for this last block as a
    trigger to send the rest of the inv blocks. If it never comes, the block
    chain download is stuck.
    
    This commit makes the receiver node always request the last inv'ed block,
    even if it is already known, to prevent this problem.
    0aa89c08ff
  5. gavinandresen referenced this in commit b2fe3a5ca6 on Mar 21, 2012
  6. gavinandresen merged this on Mar 21, 2012
  7. gavinandresen closed this on Mar 21, 2012

  8. sipa referenced this in commit d64b4fab56 on May 5, 2012
  9. sipa cross-referenced this on May 5, 2012 from issue Prevent stuck download: correct solution by sipa
  10. sipa referenced this in commit 6860133373 on May 6, 2012
  11. sipa referenced this in commit fe156fd57d on May 7, 2012
  12. luke-jr referenced this in commit 2403bb79bc on Jun 17, 2012
  13. luke-jr referenced this in commit 60953d05c8 on Jun 17, 2012
  14. coblee referenced this in commit f970cafb5a on Jul 17, 2012
  15. coblee referenced this in commit d6377bebc0 on Jul 17, 2012
  16. suprnurd referenced this in commit 67def9ef2e on Dec 5, 2017
  17. ptschip referenced this in commit 715aabfc12 on Feb 28, 2018
  18. ptschip referenced this in commit 97e5cac4a8 on Mar 7, 2018
  19. lateminer referenced this in commit 4a2b4831a9 on Oct 30, 2019
  20. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:56 UTC