travis: make distdir before make #9416

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:Mf1612-travisDistDirCheck changing 2 files +5 −3

MarcoFalke commented at 10:24 PM on December 23, 2016: member

Fix my nit on my pull: #9390 (review)
MarcoFalke added the label Tests on Dec 23, 2016
MarcoFalke added this to the milestone 0.14.0 on Dec 26, 2016
MarcoFalke added the label Build system on Dec 26, 2016
MarcoFalke force-pushed on Dec 27, 2016
MarcoFalke removed this from the milestone 0.14.0 on Dec 27, 2016
MarcoFalke force-pushed on Dec 28, 2016
MarcoFalke force-pushed on Jan 4, 2017

laanwj commented at 12:31 PM on January 5, 2017: member

Just re-triggered Travis, but this still fails two test runs.

make[1]: Entering directory `/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src'
make[2]: Entering directory `/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src'
  OBJCXXLD qt/bitcoin-qt
qt/qt_bitcoin_qt-bitcoin.o: In function `main':
bitcoin.cpp:(.text.startup+0x13d): undefined reference to `qInitResources_bitcoin()'
collect2: error: ld returned 1 exit status
make[2]: *** [qt/bitcoin-qt] Error 1
make[2]: Leaving directory `/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src'
make: *** [check-recursive] Error 1

Looks like something resource-related is missing. Possibly this:

RCC: Error in 'qt/bitcoin.qrc': Cannot find file 'res/movies/spinner-000.png'

MarcoFalke commented at 12:56 PM on January 5, 2017: member

Thanks for looking at this. @theuni already has a fix prepared for the error. Let's give him some time to prepare a pull for this.
theuni cross-referenced this on Jan 10, 2017 from issue build: fix qt distdir builds by theuni
MarcoFalke force-pushed on Jan 11, 2017
build: fix for out-of-tree/distdir qt builds 67ca130f73
theuni cross-referenced this on Jan 11, 2017 from issue build: fix qt distdir builds (retry) by theuni
MarcoFalke force-pushed on Jan 11, 2017
fanquake commented at 10:46 AM on January 11, 2017: member

@MarcoFalke Can you rebase this on #9513 so we can see the build results?
travis: make distdir before make faaf3ca0af
MarcoFalke force-pushed on Jan 11, 2017
fanquake commented at 12:17 PM on January 11, 2017: member

utACK https://github.com/bitcoin/bitcoin/pull/9416/commits/faaf3ca0af683bc6317ff4d1524eb506ab1b2ac8 tests look better here now as well.
MarcoFalke merged this on Jan 12, 2017
MarcoFalke closed this on Jan 12, 2017
MarcoFalke referenced this in commit 9ec1330b45 on Jan 12, 2017
MarcoFalke deleted the branch on Jan 12, 2017
codablock referenced this in commit c3aab0d467 on Jan 19, 2018
codablock referenced this in commit 89ac6e805b on Jan 20, 2018
codablock referenced this in commit 7dfcb15e64 on Jan 21, 2018
andvgal referenced this in commit 671cf2acd2 on Jan 6, 2019
CryptoCentric referenced this in commit 483ff3f9d2 on Feb 27, 2019
CryptoCentric referenced this in commit e11d1ae195 on Feb 27, 2019
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#9390 travis: make distdir #9509 build: fix qt distdir builds #9513 build: fix qt distdir builds (retry)