fundrawtransaction doesn't keep change address pool key #9362

issue jonasschnelli opened this issue on December 16, 2016
  1. jonasschnelli commented at 8:28 AM on December 16, 2016: contributor

    If one calls fundrawtransaction, the change address will be retrieved from the keypool, though, this key/address will always be returned to the pool, leading to the problem that the next getnewaddress() call will restult in the same key/address.

    Either we remove the auto-change-address (users would need to call getrawchangeaddress first [current best practice anyway]) or we add a call to keep/mark a specific key/address as change (after one have sent the funded raw transaction).

    Reported by @NicolasDorier on IRC.

  2. jonasschnelli added the label Wallet on Dec 16, 2016
  3. jonasschnelli cross-referenced this on Dec 16, 2016 from issue Fix fundrawtransactions address-reuse problem by jonasschnelli
  4. jonasschnelli cross-referenced this on Dec 19, 2016 from issue fundrawtransaction: Keep change-output keys by default, make it optional by jonasschnelli
  5. laanwj closed this on Jan 20, 2017

  6. gituser cross-referenced this on Dec 1, 2017 from issue fundrawtransaction address re-use by gituser
  7. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC