Add data() method to CDataStream (and use it) #9353

pull laanwj wants to merge 5 commits into bitcoin:master from laanwj:2016_12_cdatastream_data changing 5 files +19 −21

laanwj commented at 4:47 PM on December 15, 2016: member

Analogous to c++11 vector data().

Came up in #9346. Also removes a silly ancient MSVC conditional.

I've also tried to replace some uses, but I'm not 100% sure that I caught all the uses of &CDataStream[0]. As a casual git grep '&[a-zA-Z0-9_]\+\[0\]' shows the pattern is still very common for bare vectors. These uses too should be replaced with data() at some point but not here.
streams: Add data() method to CDataStream
Analogous to c++11 vector data().
af4c44ce59

streams: Remove special cases for ancient MSVC

Quite sure that we haven't supported MSVC 6.0 for ages (MSC_VER 1300 is
>= MSVC++ 7.0) but with the C++11 switch we can be sure.

a2141e415a

dbwrapper: Use new .data() method of CDataStream adff950fae
bench: Use CDataStream.data() e2300ff65e
wallet: Use CDataStream.data() 5113474a91
laanwj added the label Utils and libraries on Dec 15, 2016
paveljanik commented at 8:54 PM on December 15, 2016: contributor

ACK https://github.com/bitcoin/bitcoin/pull/9353/commits/5113474a91b8dcac4de0e4566b9babd5da281f29
sipa cross-referenced this on Dec 16, 2016 from issue Batch construct batches by sipa
laanwj renamed this:
~~Add data() method to CDataStream~~
Add data() method to CDataStream (and use it)
on Dec 19, 2016
gmaxwell commented at 9:29 AM on December 21, 2016: contributor

Concept ACK.
sipa commented at 10:54 PM on January 7, 2017: member

utACK 5113474a91b8dcac4de0e4566b9babd5da281f29
TheBlueMatt commented at 2:22 AM on January 8, 2017: contributor

utACK 5113474a91b8dcac4de0e4566b9babd5da281f29
sipa merged this on Jan 9, 2017
sipa closed this on Jan 9, 2017
sipa referenced this in commit 07fd147b9f on Jan 9, 2017
codablock referenced this in commit e70e2eb918 on Sep 27, 2017
codablock referenced this in commit bb95a8e87e on Oct 12, 2017
codablock referenced this in commit 1f344618e0 on Oct 23, 2017
codablock referenced this in commit 817ecc03d3 on Oct 23, 2017
UdjinM6 referenced this in commit eaa11803ef on Nov 8, 2017
dagurval cross-referenced this on Mar 18, 2018 from issue Add data() method to CDataStream (and use it) by dagurval
furszy cross-referenced this on Oct 26, 2020 from issue [Wallet][DB] Back ports up to the CWallet/CWalletDB/CDB refactor. by furszy
random-zebra referenced this in commit 46fad30bbb on Nov 15, 2020
str4d cross-referenced this on Jun 4, 2021 from issue v5 transaction format by str4d
str4d cross-referenced this on Jun 11, 2021 from issue Add `data()` method to `CDataStream` by str4d
zkbot referenced this in commit 332693f48c on Jun 11, 2021
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#9346 Batch construct batches