Assert FRESH validity in CCoinsViewCache::BatchWrite #9310

pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/coins-batch-assert changing 2 files +24 −11

ryanofsky commented at 6:09 PM on December 9, 2016: contributor

This change adds a check for the validity of the FRESH flag in CCoinsViewCache::BatchWrite. The check added here is analogous to the assert @morcos is adding in #9107. It is checking the same condition, just inside a different method (BatchWrite instead of ModifyNewCoins).
ryanofsky force-pushed on Dec 9, 2016
ryanofsky force-pushed on Dec 9, 2016
ryanofsky force-pushed on Dec 9, 2016

fanquake commented at 12:14 AM on December 10, 2016: member

Travis is failing on Windows

FAIL: test/test_bitcoin
=======================
Running A218 test cases...
ssertion failed!
Program: Z:\home\travis\build\bitcoin\bitcoin\build\src\test\test_bitcoin.exe
File: ../../src/coins.cpp, Line 194
Expression: !(it->second.flags & CCoinsCacheEntry::FRESH) || itUs->second.coins.IsPruned()

fanquake added the label UTXO Db and Indexes on Dec 14, 2016
ryanofsky force-pushed on Dec 19, 2016
ryanofsky force-pushed on Dec 20, 2016
ryanofsky cross-referenced this on Dec 20, 2016 from issue CCoinsViewCache code cleanup & deduplication by ryanofsky
ryanofsky force-pushed on Dec 21, 2016
ryanofsky renamed this:
~~Assert FRESH validity in CCoinsViewCache::BatchWrite (on top of #9308)~~
Assert FRESH validity in CCoinsViewCache::BatchWrite
on Dec 21, 2016
ryanofsky commented at 2:30 PM on December 21, 2016: contributor

Switched from assert to throw std::logic_error to fix the windows tests because boost execution monitor isn't able to catch asserts on windows. (Previous implementation with boost execution monitor is here: https://github.com/ryanofsky/bitcoin/commit/c3ba2d33eff8d1956b5502044854f8431ca4186d)
sipa commented at 10:53 PM on January 3, 2017: member

utACK ac10e1759910e2f14ea1d8f0912aa414047069a6
Check FRESH validity in CCoinsViewCache::BatchWrite dd44ea39bb
ryanofsky force-pushed on Jan 4, 2017
ryanofsky commented at 8:22 PM on January 4, 2017: contributor

Rebased to avoid merge conflict (in ccoins_test) with #9107.
morcos commented at 5:55 PM on January 5, 2017: member

utACK dd44ea3
TheBlueMatt commented at 1:55 AM on January 8, 2017: contributor

utACK dd44ea39bb6e1e2a244630909647ea7fbb052941 (didn't look too hard at tests, though).
sipa merged this on Jan 9, 2017
sipa closed this on Jan 9, 2017
sipa referenced this in commit 8c87f175d3 on Jan 9, 2017
codablock referenced this in commit e61ebbe411 on Sep 27, 2017
codablock referenced this in commit 319d8b1c12 on Oct 12, 2017
codablock referenced this in commit f2cf50ebf9 on Oct 23, 2017
codablock referenced this in commit 09b3e042f4 on Oct 23, 2017
UdjinM6 referenced this in commit 056ae0c6cd on Nov 8, 2017
dagurval cross-referenced this on Apr 12, 2018 from issue Coins - improve test coverage + misc by dagurval
SanJoseCosta cross-referenced this on Dec 4, 2018 from issue Bitcoind crashes with Too Many Files error by SanJoseCosta
random-zebra cross-referenced this on Aug 9, 2020 from issue [Core] Safer modify new coins by random-zebra
random-zebra referenced this in commit af793b7bb9 on Aug 18, 2020
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#9107 Safer modify new coins #9308 [test] Add CCoinsViewCache Access/Modify/Write tests #9384 CCoinsViewCache code cleanup & deduplication #14870 Bitcoind crashes with Too Many Files error