test_bitcoin fails valgrind #9278

issue TheBlueMatt opened this issue on December 5, 2016

TheBlueMatt commented at 5:11 AM on December 5, 2016: contributor

On recent master, test_bitcoin generates new valgrind warnings, specifically, rpc_tests.cpp:91 calls getnetworkinfo(), which, on rpc/net.cpp:437 looks up the connman's nLocalServices, which were never initialized (normally this would happen with CConnman::Start). @theuni might want to take a look here.
laanwj added the label Tests on Dec 5, 2016
jonasschnelli assigned theuni on Dec 5, 2016
theuni commented at 3:05 AM on December 6, 2016: member

Thanks. This really needs an Init() that the ctor and Start both call.

Will fix.
MarcoFalke added this to the milestone 0.14.0 on Dec 6, 2016
MarcoFalke added this to the milestone 0.15.0 on Jan 27, 2017
MarcoFalke removed this from the milestone 0.14.0 on Jan 27, 2017
achow101 commented at 7:44 PM on July 14, 2017: member

This is still a problem. Any fixes yet? @theuni
MarcoFalke added this to the milestone Future on Aug 1, 2017
MarcoFalke removed this from the milestone 0.15.0 on Aug 1, 2017
TheBlueMatt cross-referenced this on Aug 2, 2017 from issue [net] Fix use of uninitialized value in getnetworkinfo(const JSONRPCRequest&) by practicalswift
fanquake commented at 1:49 AM on August 9, 2017: member

Was this fixed by #10977 ?
achow101 commented at 2:15 AM on August 9, 2017: member

Looks fixed to me.
fanquake closed this on Aug 9, 2017
MarcoFalke removed this from the milestone Future on Aug 12, 2018
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#10977 [net] Fix use of uninitialized value in getnetworkinfo(const JSONRPCRequest&)