Remove unused CDiskBlockPos* argument from ProcessNewBlock #9273

pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:2016-12-remove-unused-pnb-param changing 6 files +9 −10
  1. TheBlueMatt commented at 8:24 AM on December 4, 2016: contributor

    Based on #9014 because I'm too lazy to rebase conflicting PRs everywhere, but realized the CDiskBlockPos* argument to ProcessNewBlock is entirely unused.

  2. Remove unused CDiskBlockPos* argument from ProcessNewBlock a13fa4c80f
  3. fanquake added the label Validation on Dec 4, 2016
  4. sipa commented at 7:47 AM on December 6, 2016: member

    Nice catch, this has been unused since #7917 made reindex stop using ProcessNewBlock.

    utACK a13fa4c80f792ffba8a77737754506aa849929af, but I wished github would stop showing commits that were merged elsewhere.

  5. MarcoFalke added the label Refactoring on Dec 6, 2016
  6. MarcoFalke commented at 10:02 AM on December 6, 2016: member

    utACK a13fa4c <sub>GitHub only resorts the commits after a force push. You'd have to push an empty commit and then force push it away. git checkout branchName && git commit --allow-empty && git push origin branchName && git reset --hard HEAD~ && git push origin branchName -f

  7. TheBlueMatt force-pushed on Dec 9, 2016
  8. TheBlueMatt commented at 2:06 PM on December 9, 2016: contributor

    @MarcoFalke oh thats a cool trick, didnt know that worked...anyway, did so.

  9. laanwj commented at 9:56 AM on December 14, 2016: member

    utACK a13fa4c

  10. laanwj merged this on Dec 14, 2016
  11. laanwj closed this on Dec 14, 2016

  12. laanwj referenced this in commit b68685a16a on Dec 14, 2016
  13. dagurval cross-referenced this on Jan 23, 2017 from issue Optimize reindex by dgenr8
  14. codablock referenced this in commit e34afa1067 on Jan 18, 2018
  15. gladcow cross-referenced this on Mar 1, 2018 from issue Backport compact blocks functionality from bitcoin by gladcow
  16. gladcow referenced this in commit 1d9878b5ce on Mar 5, 2018
  17. gladcow referenced this in commit 8f68ade25c on Mar 8, 2018
  18. gladcow referenced this in commit 0bdedfb10a on Mar 13, 2018
  19. gladcow referenced this in commit d1fcca2bb6 on Mar 14, 2018
  20. gladcow referenced this in commit 09e9a7c29a on Mar 15, 2018
  21. gladcow referenced this in commit 97f2dee206 on Mar 15, 2018
  22. gladcow referenced this in commit 13c95cb713 on Mar 15, 2018
  23. gladcow referenced this in commit abf27477b8 on Mar 15, 2018
  24. gladcow referenced this in commit d9a25a9391 on Mar 24, 2018
  25. gladcow referenced this in commit 4be3fd7da5 on Apr 4, 2018
  26. UdjinM6 referenced this in commit bc45a2f87a on Apr 11, 2018
  27. andvgal referenced this in commit 235c1ee0f1 on Jan 6, 2019
  28. andvgal referenced this in commit fd5c50bc2b on Jan 6, 2019
  29. CryptoCentric referenced this in commit 310c7cdcfd on Feb 26, 2019
  30. CryptoCentric referenced this in commit dd3fd51204 on Feb 28, 2019
  31. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:55 UTC