[depends] ZeroMQ 4.2.2 #9254

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:zeromq-4-2-0 changing 5 files +38 −53
  1. fanquake commented at 4:52 AM on December 1, 2016: member

    Update depends ZeroMQ to 4.2.2, the release notes are available here.

    We can drop both patches, as they have both been merged upstream (they actually had been for some time but just hadn't yet made it into a release).

    --without-documentation is deprecated and has been replaced with --without-docs. --disable-perf disables building performance measuring tools, which are enabled by default, see the libzmq configure.ac. Updated dependencies.md. --disable-curve-keygen disable building the curve key generation tool. See here.

    Can someone on windows test that this is still working correctly. Maybe @achow101 ?

  2. fanquake added the label Build system on Dec 1, 2016
  3. fanquake assigned theuni on Dec 1, 2016
  4. jonasschnelli commented at 7:53 AM on December 1, 2016: contributor

    Travis Windows (depends build) is failing. I think you need to adopt the MinGW static patches instead of removing.

  5. fanquake commented at 3:04 AM on December 2, 2016: member

    The patches were only turning this line: AC_MSG_ERROR([Building static libraries is not supported under MinGW32]) into CPPFLAGS="-DZMQ_STATIC $CPPFLAGS" (in two steps, as we wanted to use the commits from upstream). The new configure.ac now contains both patches, see here, so I think this is a different issue. Will investigate shortly.

    /usr/share/mingw-w64/include/netioapi.h:458:3: error: ‘SOCKADDR_INET’ has not been declared
   SOCKADDR_INET *BestSourceAddress
   ^
In file included from /usr/share/mingw-w64/include/iphlpapi.h:16:0,
                 from src/windows.hpp:58,
                 from src/precompiled.hpp:37,
                 from src/address.cpp:30:
/usr/share/mingw-w64/include/netioapi.h:585:9: error: ‘SOCKADDR_INET’ does not name a type
   const SOCKADDR_INET *SourceAddress
         ^
In file included from src/windows.hpp:58:0,
                 from src/precompiled.hpp:37,
                 from src/address.cpp:30:
/usr/share/mingw-w64/include/iphlpapi.h:147:5: error: ‘SOCKADDR_IN6’ does not name a type
     SOCKADDR_IN6 Ipv6Address;
     ^
  6. fanquake force-pushed on Jan 4, 2017
  7. fanquake commented at 12:51 PM on January 4, 2017: member

    Pushed a commit to update to the latest point release (4.2.1), may also help with these issues.

  8. fanquake renamed this:
    [depends] ZeroMQ 4.2.0
    [depends] ZeroMQ 4.2.1
    on Jan 4, 2017
  9. fanquake cross-referenced this on Jan 4, 2017 from issue [Depends] Dependency updates for 0.14.0 by fanquake
  10. laanwj commented at 10:42 AM on January 5, 2017: member

    Still the SOCKADDR_INET issue on win32/64

  11. fanquake force-pushed on Jan 16, 2017
  12. fanquake force-pushed on Feb 19, 2017
  13. fanquake renamed this:
    [depends] ZeroMQ 4.2.1
    [depends] ZeroMQ 4.2.2
    on Feb 19, 2017
  14. fanquake force-pushed on Mar 30, 2017
  15. laanwj commented at 10:20 AM on April 3, 2017: member

    Seems this is blocked by an upstream issue?

  16. laanwj added the label Upstream on Apr 3, 2017
  17. fanquake force-pushed on Apr 27, 2017
  18. fanquake force-pushed on Apr 27, 2017
  19. fanquake force-pushed on Apr 27, 2017
  20. fanquake cross-referenced this on May 3, 2017 from issue 0.15.0 Depends Updates by fanquake
  21. fanquake force-pushed on May 13, 2017
  22. fanquake force-pushed on May 13, 2017
  23. fanquake force-pushed on May 13, 2017
  24. laanwj added this to the milestone 0.16.0 on Aug 23, 2017
  25. fanquake force-pushed on Sep 10, 2017
  26. fanquake force-pushed on Sep 10, 2017
  27. fanquake force-pushed on Sep 10, 2017
  28. fanquake force-pushed on Sep 10, 2017
  29. fanquake force-pushed on Sep 10, 2017
  30. TheBlueMatt commented at 12:17 AM on September 29, 2017: contributor

    Has the issue been reported upstream? Any closer to resolving this one?

  31. fanquake commented at 2:37 AM on October 6, 2017: member

    @theuni Can you take a look here you have a chance? We discussed setting WINNT a while back.

  32. fanquake requested review from theuni on Oct 6, 2017
  33. fanquake force-pushed on Oct 12, 2017
  34. MarcoFalke removed this from the milestone 0.16.0 on Nov 22, 2017
  35. MarcoFalke added this to the milestone 0.17.0 on Nov 22, 2017
  36. MarcoFalke commented at 6:59 PM on November 22, 2017: member

    @fanquake Moved this to 0.17.0, since it seems stuck.

  37. theuni commented at 1:54 AM on November 29, 2017: member

    Sorry for overlooking this.

    I believe I've managed to track down the issue. @fanquake Could you try replacing your second commit with this one instead: https://github.com/theuni/bitcoin/commit/ef3ced4e0d0519c903bf115760aa3307f60a09ad ?

    That should work around the missing includes.

  38. fanquake force-pushed on Nov 29, 2017
  39. fanquake force-pushed on Nov 29, 2017
  40. fanquake force-pushed on Nov 29, 2017
  41. fanquake commented at 2:41 AM on November 29, 2017: member

    @theuni Thanks. Just had to trim the patch whitespace to keep the linter happy. Tests looks good now. Re-assigning to the 0.16.0 milestone.

  42. fanquake removed this from the milestone 0.17.0 on Nov 29, 2017
  43. fanquake added this to the milestone 0.16.0 on Nov 29, 2017
  44. fanquake force-pushed on Nov 29, 2017
  45. theuni approved
  46. theuni commented at 6:08 AM on November 29, 2017: member

    utACK 4fd7af8ec3eaebbebd1b431a6de668eeabdd8d54

  47. [depends] ZeroMQ 4.2.2 387879dd4c
  48. depends: fix zmq build with mingw < 4.0 126999d1cc
  49. fanquake force-pushed on Nov 29, 2017
  50. fanquake commented at 11:35 AM on November 29, 2017: member

    Added --disable-curve-keygen to our configure options. This option disables building the curve key generation tool, see the zeromq configure.ac.

  51. theuni commented at 5:25 PM on November 29, 2017: member

    Sure, utACK 126999d1cc1b2513cb2ca62a70db0cd6a912a7ba.

  52. laanwj merged this on Nov 30, 2017
  53. laanwj closed this on Nov 30, 2017
  54. laanwj referenced this in commit 6d3dc52b6b on Nov 30, 2017
  55. theuni cross-referenced this on Dec 21, 2017 from issue Fix gitian build after libzmq bump by theuni
  56. laanwj referenced this in commit 180a25596a on Dec 22, 2017
  57. fanquake cross-referenced this on Dec 22, 2017 from issue [depends] zeromq 4.2.3 by fanquake
  58. laanwj referenced this in commit 765a3ebb02 on Mar 6, 2018
  59. sickpig cross-referenced this on Jun 5, 2018 from issue [PORT] Depends cherries by sickpig
  60. fanquake deleted the branch on Dec 16, 2019
  61. PastaPastaPasta referenced this in commit 40031ae594 on Mar 14, 2020
  62. PastaPastaPasta referenced this in commit ce0118b613 on Mar 14, 2020
  63. deadalnix referenced this in commit 179fdb728a on Mar 27, 2020
  64. PastaPastaPasta referenced this in commit 1ea89b0285 on Mar 27, 2020
  65. PastaPastaPasta referenced this in commit 4a832e8345 on Mar 28, 2020
  66. PastaPastaPasta referenced this in commit 00de0f94d5 on Mar 29, 2020
  67. PastaPastaPasta referenced this in commit 652bb16d21 on Mar 31, 2020
  68. UdjinM6 referenced this in commit a6b3d7d2a6 on Mar 31, 2020
  69. PastaPastaPasta referenced this in commit 7b1f32082c on Apr 1, 2020
  70. 10xcryptodev referenced this in commit 8cc575cced on May 16, 2020
  71. 10xcryptodev referenced this in commit 45db031556 on May 17, 2020
  72. str4d cross-referenced this on Oct 5, 2020 from issue Update ZeroMQ by str4d
  73. zkbot referenced this in commit e3d5ddbef4 on Oct 8, 2020
  74. zkbot referenced this in commit 6e4090d840 on Oct 8, 2020
  75. ckti referenced this in commit 4e88546e3d on Mar 28, 2021
  76. ckti referenced this in commit 1ece1b4028 on Mar 28, 2021
  77. gades referenced this in commit 6db1fa619c on Jun 24, 2021
  78. CryptoCentric referenced this in commit dc6ddfc2e0 on Jul 2, 2021
  79. CryptoCentric referenced this in commit 7732baefae on Jul 2, 2021
  80. CryptoCentric referenced this in commit 430e0c7120 on Jul 2, 2021
  81. ftrader referenced this in commit 44d102f75f on Aug 13, 2021
  82. bitcoin locked this on Dec 16, 2021
Contributors
fanquakejonasschnellilaanwjTheBlueMattMarcoFalketheuni
Labels
Build systemUpstream

Milestone
0.16.0

Linked (view graph)
#9468 [Depends] Dependency updates for 0.14.0#10325 0.15.0 Depends Updates#11981 Fix gitian build after libzmq bump#11986 [depends] zeromq 4.2.3
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC