Fix calculation of number of bound sockets to use #9253

pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:2016-11-nbind changing 1 files +3 −1

TheBlueMatt commented at 2:56 AM on December 1, 2016: contributor

Pulled this out of #9243 because it is a logically separate change.
Fix calculation of number of bound sockets to use 9e1f46821d
TheBlueMatt cross-referenced this on Dec 1, 2016 from issue Clean up mapArgs and mapMultiArgs Usage by TheBlueMatt
fanquake added the label Bug on Dec 1, 2016
fanquake added the label Needs backport on Dec 1, 2016
sipa commented at 6:36 AM on December 1, 2016: member

utACK 9e1f46821d5bb69e2cbf25738eefa7c6cb99c838
laanwj commented at 7:05 AM on December 1, 2016: member

utACK https://github.com/bitcoin/bitcoin/commit/9e1f46821d5bb69e2cbf25738eefa7c6cb99c838
paveljanik commented at 7:18 AM on December 1, 2016: contributor

What is returned by mapMultiArgs.at("-bind").size() if !mapMultiArgs.count("-bind")? Do we need the condition at all? Edit: answering to myself: std::out_of_range exception is thrown.
sipa commented at 7:21 AM on December 1, 2016: member

@paveljanik It would raise an exception. Using [] instead would result in adding "-bind" as a key to the map.
paveljanik commented at 7:24 AM on December 1, 2016: contributor

ACK 9e1f468
jonasschnelli commented at 7:44 AM on December 1, 2016: contributor

utACK 9e1f46821d5bb69e2cbf25738eefa7c6cb99c838
gmaxwell commented at 10:52 AM on December 1, 2016: contributor

utACK
instagibbs commented at 4:56 PM on December 1, 2016: member

utACK 9e1f46821d5bb69e2cbf25738eefa7c6cb99c838
morcos commented at 8:59 PM on December 1, 2016: member

utACK @laanwj ready for merge
sipa merged this on Dec 1, 2016
sipa closed this on Dec 1, 2016
sipa referenced this in commit c1a5227684 on Dec 1, 2016
luke-jr referenced this in commit 28d0f224fd on Dec 2, 2016
laanwj added the label P2P on Dec 19, 2016
laanwj removed the label Needs backport on Sep 5, 2017
codablock referenced this in commit 0fe5659211 on Jan 16, 2018
codablock referenced this in commit ae526a19fc on Jan 16, 2018
codablock referenced this in commit 180e379e2d on Jan 17, 2018
lateminer referenced this in commit 39e1d793ce on Oct 24, 2018
andvgal referenced this in commit e555586024 on Jan 6, 2019
CryptoCentric referenced this in commit 9a095848bf on Feb 25, 2019
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#9243 Clean up mapArgs and mapMultiArgs Usage