bench: Fix subtle counting issue when rescaling iteration count #9200

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2016_11_bench_fix changing 1 files +5 −2

laanwj commented at 9:00 AM on November 22, 2016: member

Make sure that the count is a zero modulo the new mask before scaling, otherwise the next time until a measure triggers will take only 1/2 as long as accounted for. This caused the 'min time' to be potentially off by as much as 100%.
laanwj added the label Tests on Nov 22, 2016

bench: Fix subtle counting issue when rescaling iteration count

Make sure that the count is a zero modulo the new mask before
scaling, otherwise the next time until a measure triggers
will take only 1/2 as long as accounted for. This caused
the 'min time' to be potentially off by as much as 100%.

e0a9cb25b0

laanwj force-pushed on Nov 22, 2016
jonasschnelli commented at 9:17 AM on November 22, 2016: contributor

Uh. Good catch. utACK e0a9cb25b0af87723d50cb8d8cffa10f1ebf7dcc
gmaxwell commented at 9:51 AM on November 22, 2016: contributor

looks good to me utACK.
laanwj merged this on Nov 22, 2016
laanwj closed this on Nov 22, 2016
laanwj referenced this in commit 55b2eddcc8 on Nov 22, 2016
luke-jr referenced this in commit eebc699d30 on Dec 2, 2016
codablock referenced this in commit 481bab7456 on Jan 15, 2018
dagurval cross-referenced this on Apr 30, 2018 from issue Benchmark cherries by dagurval
lateminer referenced this in commit 3cbcdbd9a1 on Oct 24, 2018
andvgal referenced this in commit 34c9031c36 on Jan 6, 2019
str4d cross-referenced this on Feb 22, 2019 from issue Micro-benchmarking framework part 1 by str4d
CryptoCentric referenced this in commit 76d41e5e21 on Feb 24, 2019
zkbot referenced this in commit aa225ebb0b on Jan 24, 2020
zkbot referenced this in commit 74ff73abab on Jan 24, 2020
sickpig cross-referenced this on Apr 28, 2020 from issue Update benchmark suite by sickpig
random-zebra cross-referenced this on May 27, 2020 from issue [Tests] Benchmarking Framework by random-zebra
furszy referenced this in commit 4ed15cc69d on Jun 8, 2020
bitcoin locked this on Sep 8, 2021

Contributors

Labels