mempool saving doesn't save mempoolminfee #9103

issue gmaxwell opened this issue on November 8, 2016

gmaxwell commented at 7:17 PM on November 8, 2016: contributor

mempool saving doesn't save mempoolminfee so it goes immediately to zero after a restart. It should probably be saved.
MarcoFalke added the label TX fees and policy on Nov 8, 2016
rebroad commented at 3:20 AM on November 13, 2016: contributor

I don't really see a problem with this - it will soon set once the mempool usage is utilized. Not sure why we'd want to start filtering prematurely anyway.
sdaftuar cross-referenced this on Dec 1, 2016 from issue Mempool saving should save the current mempoolminfee by gmaxwell
sipa commented at 7:17 PM on December 1, 2016: member

@rebroad Because you're briefly in a situation with an unrealistic state, where obviously-unacceptable things do get accepted (and very quickly evicted). This could impact the wallet behaviour for example.
morcos commented at 8:36 PM on December 1, 2016: member

I think if we are going to do this (which I'm not convinced is worth it) then its probably important to save the time state necessary to decay the mempool min fee as well.
luke-jr cross-referenced this on Dec 25, 2016 from issue Refactor mempool.dat to be extensible, and store missing info by luke-jr
MarcoFalke added the label Mempool on Feb 9, 2018
laanwj commented at 12:36 PM on May 14, 2018: member

Closing after the discussion in #9422 - apparently this is deemed not worth it, at least right now.
laanwj closed this on May 14, 2018
bitcoin locked this on Sep 8, 2021

Contributors

Labels

TX fees and policy Mempool

Linked (view graph)

#9258 Mempool saving should save the current mempoolminfee #9422 Refactor mempool.dat to be extensible, and store missing info