As briefly discussed in #8708 (which conflicts here, I'll fix one up post-merge of the other). @sipa is siphash of a single incrementing int strong enough here for preventing fingerprinting?
net: make a few values immutable, and use deterministic randomness for the localnonce #9050
pull theuni wants to merge 2 commits into bitcoin:master from theuni:connman-const changing 4 files +33 −23-
theuni commented at 10:02 PM on October 31, 2016: member
-
net: constify a few CNode vars to indicate that they're threadsafe aff6584e09
-
net: Use deterministic randomness for CNode's nonce, and make it const 59ac5c5b72
-
theuni commented at 10:39 PM on October 31, 2016: member
As discussed on IRC, Travis failure unrelated.
-
MarcoFalke commented at 10:28 AM on November 1, 2016: member
Rerun and archived failure here:
test count = ../../../src/secp256k1/src/tests.c64 random seed = 803fa67dcab64b4b14a4c0089a34e7b6 :393: test condition failed: ((~x[m][shift]) << (64 - (1 << usebits))) == 0 - MarcoFalke added the label P2P on Nov 1, 2016
- laanwj renamed this:
net: make a few values immutible, and use deterministic randomness for the localnonce
net: make a few values immutable, and use deterministic randomness for the localnonce
on Nov 2, 2016 -
sipa commented at 12:53 AM on November 3, 2016: member
utACK aff6584e09938768838a768b67722db553cf8ef4
-
laanwj commented at 9:13 AM on November 3, 2016: member
utACK https://github.com/bitcoin/bitcoin/commit/aff6584e09938768838a768b67722db553cf8ef4, though @MarcoFalke 's crash seems worrying.
-
sipa commented at 9:23 AM on November 3, 2016: member
@MarcoFalke's failure is a randomness test in libsecp256k1 that has a very low (but still too high) false positive rate.
- laanwj merged this on Nov 3, 2016
- laanwj closed this on Nov 3, 2016
- laanwj referenced this in commit fcf61b80fa on Nov 3, 2016
- theuni cross-referenced this on Nov 3, 2016 from issue net: have CConnman handle message sending by theuni
- codablock referenced this in commit 98e8c31a92 on Sep 19, 2017
- codablock referenced this in commit dd7669bc7c on Jan 13, 2018
- dagurval cross-referenced this on May 26, 2018 from issue Net cherries by dagurval
- andvgal referenced this in commit 3ed2df9327 on Jan 6, 2019
- Fuzzbawls cross-referenced this on Sep 3, 2020 from issue [Net] Massive network refactoring and speedup by Fuzzbawls
- random-zebra referenced this in commit cbd9271afb on Sep 7, 2020
- bitcoin locked this on Sep 8, 2021
Contributors
Labels