[0.13 backport] Fix handling of invalid compact blocks #9048

1. 
   sdaftuar commented at 2:46 PM on October 31, 2016: member

   Backport of #9026 to 0.13.

2. [qa] Test that invalid compactblocks don't result in ban 82905069bf
3. fanquake added this to the milestone 0.13.2 on Nov 1, 2016
4. fanquake added the label Backport on Nov 1, 2016
5. sdaftuar cross-referenced this on Nov 1, 2016 from issue Fix handling of invalid compact blocks by sdaftuar
6. 
   sdaftuar commented at 4:52 PM on November 1, 2016: member

   Updated this to match the latest changes in #9026 (see #9026 (comment)).

7. Fix compact block handling to not ban if block is invalid 015865ee9e
8. sdaftuar force-pushed on Nov 1, 2016
9. Bump the protocol version to distinguish new banning behavior.

   This allows future software that would relay compact blocks before
   full validation to announce only to peers that will not ban if the
   block turns out to be invalid.

   e8ef50ba51
10. sdaftuar force-pushed on Nov 1, 2016
11. in src/main.cpp:None in e8ef50ba51

    4718 | @@ -4717,7 +4719,6 @@ std::string GetWarnings(const std::string& strFor)
    4719 |  
    4720 |  
    4721 |  //////////////////////////////////////////////////////////////////////////////
    4722 | -//
    

    ---

    ---

    

    TheBlueMatt commented at 2:48 PM on November 2, 2016:

    Wut?

    ---

    

    sdaftuar commented at 12:56 PM on November 3, 2016:

    Oops, fixed.

12. 
    TheBlueMatt commented at 3:05 PM on November 2, 2016: contributor

    utACK e8ef50ba51968da67a36c9fae6938d868b434da2, minus random line removal. Looks equivalent to #9026.

13. TheBlueMatt cross-referenced this on Nov 3, 2016 from issue Decouple peer-processing-logic from block-connection-logic (#3) by TheBlueMatt
14. laanwj merged this on Nov 9, 2016
15. laanwj closed this on Nov 9, 2016

    ---

16. laanwj referenced this in commit 9460771a60 on Nov 9, 2016
17. OlegGirko cross-referenced this on Aug 1, 2017 from issue Backport Bitcoin PR#9075: Decouple peer-processing-logic from block-connection-logic (#3) by OlegGirko
18. bitcoin locked this on Sep 8, 2021

Contributors

sdaftuarTheBlueMatt

Milestone
0.13.2