Clarify `listenonion` #9004

pull unsystemizer wants to merge 1 commits into bitcoin:master from unsystemizer:patch-3 changing 1 files +4 −4

unsystemizer commented at 7:50 AM on October 24, 2016: contributor
This new feature is enabled by default if Bitcoin Core is listening, and a connection to Tor can be made. It can be configured with the -listenonion, -torcontrol and -torpassword settings. To show verbose debugging information, pass -debug=tor.

But it is correct to say that the feature is enabled regardless of whether a connection to Tor can be made.

I propose to clarify that so that users can eliminate these in their logs (when listen=1 and no Tor). And I think it's okay to clarify about the listen option, because on several occasions when I read this before I always assumed listening meant server=1 which cost me a lot of time in troubleshooting.
```
2016-10-24 06:19:22.551029 tor: Error connecting to Tor control socket
2016-10-24 06:19:22.551700 tor: Not connected to Tor control port 127.0.0.1:9051, trying to reconnect
```
What version of bitcoin-core are you using?

0.12.1

Clarify `listenonion`

> This new feature is enabled by default if Bitcoin Core is listening, and a connection to Tor can be made. It can be configured with the -listenonion, -torcontrol and -torpassword settings. To show verbose debugging information, pass -debug=tor.

But it is correct to say that the feature is enabled *regardless* of whether a connection to Tor can be made.

I propose to clarify that so that users can eliminate these in their logs (when `listen=1` and no Tor).
And I think it's okay to clarify about the `listen` option, because on several occasions when I read this before I always assumed `listening` meant `server=1` which cost me a lot of time in troubleshooting.

```
2016-10-24 06:19:22.551029 tor: Error connecting to Tor control socket
2016-10-24 06:19:22.551700 tor: Not connected to Tor control port 127.0.0.1:9051, trying to reconnect
```

### What version of bitcoin-core are you using?
0.12.1

3421e74601

fanquake added the label Docs and Output on Oct 24, 2016
laanwj commented at 7:58 AM on October 24, 2016: member

Yes, server and listen are named awkwardly, one relates to RPC where the other does to P2P. Documentation change looks good to me.
btcdrak commented at 6:51 PM on October 24, 2016: contributor

ACK
laanwj merged this on Oct 25, 2016
laanwj closed this on Oct 25, 2016
laanwj referenced this in commit 67728a389c on Oct 25, 2016
unsystemizer deleted the branch on Oct 25, 2016
str4d cross-referenced this on Mar 24, 2017 from issue Tor ephemeral hidden services by str4d
zkbot referenced this in commit 45faa928ec on Mar 26, 2017
codablock referenced this in commit c339a3af22 on Sep 19, 2017
codablock referenced this in commit 55cabaa213 on Jan 13, 2018
andvgal referenced this in commit 82387ab223 on Jan 6, 2019
bitcoin locked this on Sep 8, 2021

Contributors

Labels