Add x9 service bit support to dnsseed.bluematt.me #8940

1. 
   TheBlueMatt commented at 3:26 PM on October 17, 2016: contributor

   No description provided.

2. MarcoFalke added the label Needs backport on Oct 17, 2016
3. MarcoFalke added this to the milestone 0.13.1 on Oct 17, 2016
4. MarcoFalke added the label P2P on Oct 17, 2016
5. 
   MarcoFalke commented at 4:32 PM on October 17, 2016: member

   ACK e5f8b0d

6. in src/chainparams.cpp:None in e5f8b0dc18 outdated

    112 | @@ -113,12 +113,13 @@ class CMainParams : public CChainParams {
    113 |          assert(consensus.hashGenesisBlock == uint256S("0x000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f"));
    114 |          assert(genesis.hashMerkleRoot == uint256S("0x4a5e1e4baab89f3a32518a88c31bc87f618f76673e2cc77ab2127b7afdeda33b"));
    115 |  
    116 | -        vSeeds.push_back(CDNSSeedData("bitcoin.sipa.be", "seed.bitcoin.sipa.be", true)); // Pieter Wuille
    117 | -        vSeeds.push_back(CDNSSeedData("bluematt.me", "dnsseed.bluematt.me")); // Matt Corallo
    118 | +        // Note that of those with the service bits flag, most only support a subset of possible options
    119 | +        vSeeds.push_back(CDNSSeedData("bitcoin.sipa.be", "seed.bitcoin.sipa.be", true)); // Pieter Wuille, only supports x1, x5, x9, and x13
   

   ---

   ---

   

   MarcoFalke commented at 4:33 PM on October 17, 2016:

   Are you sure @sipa supports x13. (Right now I don't get an answer)

   ---

   

   sipa commented at 5:30 PM on October 17, 2016:

   Yes. There are just no matches.

7. 
   laanwj commented at 5:16 PM on October 17, 2016: member

   Can we merge "Marking filter support for cdecker's DNS seed #8941" into this? Would make sense to do this update at the same time.

8. laanwj cross-referenced this on Oct 17, 2016 from issue Marking filter support for cdecker's DNS seed by cdecker
9. 
   TheBlueMatt commented at 5:28 PM on October 17, 2016: contributor

   Included #8941.

10. 
    cdecker commented at 5:29 PM on October 17, 2016: contributor

    Thanks Matt, closing #8941

11. Comment that most dnsseeds only support some service bits combos 504c72ad34
12. Add x9 service bit support to dnsseed.bluematt.me ffb4713920
13. My DNS seed supports filtering

    Currently supports filtering by any combination of the 4 least
    significant bits.

    2449e12681
14. TheBlueMatt force-pushed on Oct 17, 2016
15. 
    laanwj commented at 5:36 PM on October 17, 2016: member

    utACK 2449e12

16. 
    MarcoFalke commented at 5:37 PM on October 17, 2016: member

    utACK 2449e12

17. 
    btcdrak commented at 5:37 PM on October 17, 2016: contributor

    utACK 2449e12681ab549695f143d9b3ad2c24be03a78d

18. laanwj merged this on Oct 17, 2016
19. laanwj closed this on Oct 17, 2016

    ---

20. laanwj referenced this in commit 763828df49 on Oct 17, 2016
21. 
    sipa commented at 5:38 PM on October 17, 2016: member

    utACK

22. laanwj referenced this in commit 9aa0c15972 on Oct 17, 2016
23. laanwj referenced this in commit 3d770a88d3 on Oct 17, 2016
24. laanwj referenced this in commit 5b4192bc4c on Oct 17, 2016
25. 
    jonasschnelli commented at 6:23 AM on October 18, 2016: contributor

    post merge ACK

26. laanwj removed the label Needs backport on Oct 18, 2016
27. bitcoin locked this on Sep 8, 2021

Contributors

TheBlueMattMarcoFalkesipalaanwjcdeckerbtcdrakjonasschnelli

Milestone
0.13.1