Define start and end time for segwit deployment #8937

pull sipa wants to merge 1 commits into bitcoin:master from sipa:bip141start changing 2 files +5 −5

sipa commented at 11:26 AM on October 17, 2016: member

See corresponding mailing list discussion (https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2016-October/013226.html) and BIP update PR (https://github.com/bitcoin/bips/pull/464).
fanquake added the label Consensus on Oct 17, 2016
Define start and end time for segwit deployment f9c23dea97
in src/chainparams.cpp:None in 4d31f97daa outdated
```
  92 | @@ -93,8 +93,8 @@ class CMainParams : public CChainParams {
  93 |  
  94 |          // Deployment of SegWit (BIP141 and BIP143)
```
btcdrak commented at 12:07 PM on October 17, 2016:

also BIP147

sipa commented at 12:16 PM on October 17, 2016:

Fixed.
sipa force-pushed on Oct 17, 2016
laanwj added this to the milestone 0.13.1 on Oct 17, 2016
laanwj added the label Needs backport on Oct 17, 2016
btcdrak commented at 1:15 PM on October 17, 2016: contributor

utACK f9c23dea976465c51b9fe2cead81b707678c16bb
achow101 commented at 1:20 PM on October 17, 2016: member

utACK f9c23dea976465c51b9fe2cead81b707678c16bb
JornC commented at 1:45 PM on October 17, 2016: none

Start: http://www.wolframalpha.com/input/?i=unix+1479168000

12:00:00 am UTC | Tuesday, November 15, 2016

End: http://www.wolframalpha.com/input/?i=unix+1510704000

12:00:00 am UTC | Wednesday, November 15, 2017

utACK f9c23dea976465c51b9fe2cead81b707678c16bb
instagibbs commented at 1:54 PM on October 17, 2016: member

11/15/2016 @ 12:00am (UTC) to 11/15/2017 @ 12:00am (UTC)

utACK https://github.com/bitcoin/bitcoin/pull/8937/commits/f9c23dea976465c51b9fe2cead81b707678c16bb
in src/chainparams.cpp:None in f9c23dea97
```
  90 | @@ -91,10 +91,10 @@ class CMainParams : public CChainParams {
  91 |          consensus.vDeployments[Consensus::DEPLOYMENT_CSV].nStartTime = 1462060800; // May 1st, 2016
  92 |          consensus.vDeployments[Consensus::DEPLOYMENT_CSV].nTimeout = 1493596800; // May 1st, 2017
  93 |  
  94 | -        // Deployment of SegWit (BIP141 and BIP143)
  95 | +        // Deployment of SegWit (BIP141, BIP143, and BIP147)
```
paveljanik commented at 1:54 PM on October 17, 2016:

No need for comma before "and".

sipa commented at 1:56 PM on October 17, 2016:

Depends: https://en.wikipedia.org/wiki/Serial_comma

instagibbs commented at 1:56 PM on October 17, 2016:

NACK, Oxford comma for life.

paveljanik commented at 1:59 PM on October 17, 2016:

Yes, I'm on the "against" side, sorry.

paveljanik commented at 2:01 PM on October 17, 2016:

BIP141, BIP143, BIP147,

C forever! ;-)

btcdrak commented at 2:12 PM on October 17, 2016:

Brit here, I approve of Oxford comma!

Leviathn commented at 3:59 PM on October 17, 2016:

Oxford comma is best practice.

rebroad commented at 5:09 AM on November 6, 2016:

honestly... does it even matter?!

in src/chainparams.cpp:None in f9c23dea97

  90 | @@ -91,10 +91,10 @@ class CMainParams : public CChainParams {
  91 |          consensus.vDeployments[Consensus::DEPLOYMENT_CSV].nStartTime = 1462060800; // May 1st, 2016
  92 |          consensus.vDeployments[Consensus::DEPLOYMENT_CSV].nTimeout = 1493596800; // May 1st, 2017
  93 |  
  94 | -        // Deployment of SegWit (BIP141 and BIP143)
  95 | +        // Deployment of SegWit (BIP141, BIP143, and BIP147)
  96 |          consensus.vDeployments[Consensus::DEPLOYMENT_SEGWIT].bit = 1;
  97 | -        consensus.vDeployments[Consensus::DEPLOYMENT_SEGWIT].nStartTime = 0;
  98 | -        consensus.vDeployments[Consensus::DEPLOYMENT_SEGWIT].nTimeout = 0; // Never / undefined
  99 | +        consensus.vDeployments[Consensus::DEPLOYMENT_SEGWIT].nStartTime = 1479168000; // November 15th, 2016.

paveljanik commented at 1:56 PM on October 17, 2016:

No need for dot at the end of the line. This is the third format for simple date we use now (as shown in the Files changed in this PR) :-)

murchandamus commented at 11:50 PM on October 17, 2016:

Glory to ISO 8601. Should be 2016-11-15. ;)

paveljanik commented at 1:57 PM on October 17, 2016: contributor

ACK /me too for simple epoch conversion ;-)
TheBlueMatt commented at 2:14 PM on October 17, 2016: contributor

utACK f9c23dea976465c51b9fe2cead81b707678c16bb
jameshilliard commented at 2:23 PM on October 17, 2016: contributor

utACK https://github.com/bitcoin/bitcoin/commit/f9c23dea976465c51b9fe2cead81b707678c16bb
jl2012 commented at 2:30 PM on October 17, 2016: contributor

utACK f9c23de
laanwj commented at 2:33 PM on October 17, 2016: member

utACK https://github.com/bitcoin/bitcoin/pull/8937/commits/f9c23dea976465c51b9fe2cead81b707678c16bb. Timestamps match those in the BIP update https://github.com/bitcoin/bips/pull/464/commits/5c2da7e07d924c34af4edf7098981c9a376263d2, which matches the UTC dates in the mailing list post. Let's not hold this up on comment formatting minutia.
laanwj merged this on Oct 17, 2016
laanwj closed this on Oct 17, 2016
laanwj referenced this in commit c6b959efcf on Oct 17, 2016
laanwj referenced this in commit 8b66659921 on Oct 17, 2016
laanwj removed the label Needs backport on Oct 17, 2016
ftrader cross-referenced this on Oct 17, 2016 from issue update SegWit triggering after Core merge of deployment parameters for BIP141/143/147 by ftrader
ftrader cross-referenced this on Oct 17, 2016 from issue Clarify and fix the SegWit trigger condition by ftrader
dcousens commented at 11:24 PM on October 17, 2016: contributor

utACK 8b66659
ftrader cross-referenced this on Nov 4, 2016 from issue Clarify and fix the SegWit trigger condition by ftrader
rebroad cross-referenced this on Nov 6, 2016 from issue Disk IO > 90% on when running 0.13.1 on Ubuntu by vogelito
ajtowns cross-referenced this on Apr 15, 2021 from issue Speedy trial activation parameters for Taproot by achow101
bitcoin locked this on Sep 8, 2021