Set minimum required Boost to 1.47.0 #8920

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:set-minimum-boost changing 2 files +6 −3

fanquake commented at 4:34 AM on October 14, 2016: member

Boost is on the way out, but in the mean time, having the minimum set to 1.20.0 is misleading, and can lead to issues like #8868.

1.47.0 is the first version to include Chrono. See #8875 for some history.
fanquake added the label Utils and libraries on Oct 14, 2016

in build-aux/m4/ax_boost_base.m4:None in bc83e23c70 outdated

  95 | @@ -96,7 +96,7 @@ if test "x$want_boost" = "xyes"; then
  96 |          libsubdirs="lib64 libx32 lib lib64"
  97 |          ;;
  98 |        ppc64|s390x|sparc64|aarch64|ppc64le)
  99 | -        libsubdirs="lib64 lib lib64 ppc64le"

paveljanik commented at 6:29 AM on October 14, 2016:

Eh?

in build-aux/m4/ax_boost_base.m4:None in bc83e23c70 outdated
```
  32 | @@ -33,7 +33,7 @@
  33 |  #   and this notice are preserved. This file is offered as-is, without any
  34 |  #   warranty.
  35 |  
  36 | -#serial 26
  37 | +#serial 27
```
paveljanik commented at 6:31 AM on October 14, 2016:

The serial should reflect the original version used as a base - coming from https://www.gnu.org/software/autoconf-archive/ax_boost_base.html
paveljanik commented at 6:33 AM on October 14, 2016: contributor

So you are updating the file to match and at the same time upgrading the minimal requirement. Please always mention this in the PR text and not hide the first part.

Changes like this should be done in two commits, I think.
luke-jr commented at 8:47 AM on October 14, 2016: member

Concept ACK, but shouldn't some documentation need updating as well?
in build-aux/m4/ax_boost_base.m4:None in bc83e23c70 outdated
```
  71 | @@ -72,7 +72,7 @@ AC_ARG_WITH([boost-libdir],
  72 |  )
  73 |  
  74 |  if test "x$want_boost" = "xyes"; then
  75 | -    boost_lib_version_req=ifelse([$1], ,1.20.0,$1)
  76 | +    boost_lib_version_req=ifelse([$1], ,1.47.0,$1)
```
laanwj commented at 7:14 AM on October 15, 2016:

concept ACK - though personally I'd prefer passing in this version as a parameter from our configure.ac, if possible, instead of changing this upstream file
laanwj commented at 7:16 AM on October 15, 2016: member

Concept ACK, but shouldn't some documentation need updating as well?

If only we had documentation for minimum version requirements, it should be updated. But doesn't look like we do, build-unix only lists the libraries necessary not their minimum supported versions. We've never really kept track of those.
laanwj assigned theuni on Oct 15, 2016
laanwj cross-referenced this on Oct 15, 2016 from issue Need documentation on minimum supported dependency versions by laanwj
fanquake cross-referenced this on Oct 17, 2016 from issue Docs: Minimum required dependencies and current CVEs by fanquake
[build-aux] Boost_Base serial 27 282abd8358
Set minimum required Boost to 1.47.0 6dd3723722
fanquake force-pushed on Oct 17, 2016
paveljanik approved
paveljanik commented at 6:49 AM on October 17, 2016: contributor

This looks much better, thank you!

ACK https://github.com/bitcoin/bitcoin/pull/8920/commits/6dd37237222f7102e223ece948150cb5c5087e3c
paveljanik commented at 6:49 AM on October 17, 2016: contributor
Build log diff:
```
-checking for boostlib >= 1.20.0... yes
+checking for boostlib >= 1.47.0... yes
```
Great!
jonasschnelli commented at 6:54 AM on October 17, 2016: contributor

utACK 6dd37237222f7102e223ece948150cb5c5087e3c
MarcoFalke commented at 8:00 AM on October 17, 2016: member

utACK 6dd3723
laanwj merged this on Oct 17, 2016
laanwj closed this on Oct 17, 2016
laanwj referenced this in commit c901113144 on Oct 17, 2016
fanquake deleted the branch on Oct 17, 2016
theuni commented at 5:26 PM on October 17, 2016: member

post-merge ACK.
Zenitur commented at 7:16 PM on November 4, 2016: none

An error when build with Boost 1.49: http://pastebin.com/b2JHAE01
paveljanik commented at 11:55 AM on November 5, 2016: contributor

@Zenitur Upstream bug https://svn.boost.org/trac/boost/ticket/6790
Zenitur commented at 5:22 AM on November 6, 2016: none

@paveljanik now it works. Thank you!
luke-jr referenced this in commit c134d9206d on Dec 2, 2016
luke-jr referenced this in commit 40169dcda9 on Dec 2, 2016
laanwj cross-referenced this on Feb 8, 2017 from issue Bump minimum required Boost version by fanquake
laanwj referenced this in commit 763ef23ef4 on Feb 9, 2017
laanwj cross-referenced this on Feb 9, 2017 from issue Remove fallbacks for boost_filesystem < v3 by laanwj
laanwj referenced this in commit 056aba2b4f on Feb 10, 2017
codablock referenced this in commit 283a461552 on Sep 19, 2017
schinzelh referenced this in commit 74394f1387 on Oct 23, 2017
schinzelh referenced this in commit 938a6fbde6 on Oct 23, 2017
codablock referenced this in commit 19316b7a63 on Jan 12, 2018
HashUnlimited referenced this in commit 88b536ca16 on Feb 27, 2018
lateminer referenced this in commit cae922d164 on Oct 16, 2018
lateminer referenced this in commit 31be10f37d on Oct 16, 2018
lateminer referenced this in commit da76c0a422 on Jun 23, 2019
hebasto cross-referenced this on Jul 13, 2019 from issue Set minimum required Boost to 1.53.0 by hebasto
jnewbery cross-referenced this on Dec 11, 2020 from issue Move SaltedHashers to separate file and add some new ones by achow101
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8639 Docs: Minimum required dependencies and current CVEs #8868 You need to increase minimal required Boost version (or fix the issue)#8875 Bump minimum required Boost version #8923 Need documentation on minimum supported dependency versions #9727 Remove fallbacks for boost_filesystem < v3 #16381 Set minimum required Boost to 1.53.0 #19935 Move SaltedHashers to separate file and add some new ones