qt: Translate all files, even if wallet disabled #8911

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2016_10_qt_translations_wallet2 changing 1 files +11 −7
  1. laanwj commented at 3:49 PM on October 11, 2016: member

    This passes all QT cpp files to the lupdate executable which extracts translations, no matter what conditional functionality is enabled.

    This is already done correctly when extracting strings from core:

    $(srcdir)/qt/bitcoinstrings.cpp: $(libbitcoin_server_a_SOURCES) $(libbitcoin_wallet_a_SOURCES)
    

    This should prevent issues like #8900 and #8782 in the future.

  2. qt: Translate all files, even if wallet disabled
    This passes all QT cpp files to the lupdate executable which extracts
    translations, no matter what conditional functionality is enabled.
    8aed5f6c23
  3. laanwj added the label GUI on Oct 11, 2016
  4. laanwj added the label Docs and Output on Oct 11, 2016
  5. laanwj added the label Wallet on Oct 11, 2016
  6. MarcoFalke commented at 3:58 PM on October 11, 2016: member

    utACK 8aed5f6c23cbaae6bf56be04f2b8d861eacf588d

  7. MarcoFalke added this to the milestone 0.13.1 on Oct 11, 2016
  8. MarcoFalke added the label Needs backport on Oct 11, 2016
  9. achow101 commented at 4:07 PM on October 11, 2016: member

    utACK 8aed5f6c23cbaae6bf56be04f2b8d861eacf588d

  10. laanwj merged this on Oct 13, 2016
  11. laanwj closed this on Oct 13, 2016

  12. laanwj referenced this in commit 8d46429c83 on Oct 13, 2016
  13. laanwj referenced this in commit 7634d8eac4 on Oct 13, 2016
  14. fanquake cross-referenced this on Oct 13, 2016 from issue Untranslated strings in GUI by FabioCarpi-zz
  15. fanquake cross-referenced this on Oct 13, 2016 from issue qt: Missing translations by MarcoFalke
  16. MarcoFalke removed the label Needs backport on Oct 13, 2016
  17. codablock referenced this in commit 91ac895cb3 on Sep 19, 2017
  18. codablock referenced this in commit dcc63e6e9f on Jan 12, 2018
  19. andvgal referenced this in commit 3c3fadf423 on Jan 6, 2019
  20. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:55 UTC