Built on #8871, this removes the fetch logic from INV message processing. it is rare that we care strongly about the speed of fetch in case we receive an INV, plus we found that code which did not have knowledge of the associated tip when requesting was more fragile in the context of segwit activation. Finally, this removes the one place we MarkBlockAsInFlight (ie will forcibly store the block on disk in AcceptBlock) without having seen the header first.
Remove block-request logic from INV message processing #8872
pull TheBlueMatt wants to merge 3 commits into bitcoin:master from TheBlueMatt:fetchflags2 changing 5 files +46 −31-
TheBlueMatt commented at 6:40 PM on October 3, 2016: contributor
- TheBlueMatt cross-referenced this on Oct 3, 2016 from issue Fix direct headers announcement to Bitcoin Core nodes by TheBlueMatt
- TheBlueMatt cross-referenced this on Oct 3, 2016 from issue Bitcoin Unlimited/XThin Sendheaders quirk may result in extra roundtrip from Bitcoin Core by TheBlueMatt
- TheBlueMatt force-pushed on Oct 3, 2016
- TheBlueMatt force-pushed on Oct 3, 2016
-
TheBlueMatt commented at 9:11 PM on October 4, 2016: contributor
Fixed all the tests now. @mrbandrews might want to review the changes to fullblocktest...I dont think I broke anything, but would be good to get some review there.
- laanwj added the label P2P on Oct 11, 2016
-
rebroad commented at 1:12 AM on October 19, 2016: contributor
NACK for now as I see the additional block propagation speed as more important - or I am falsely assuming this will decrease block propagation times?
-
TheBlueMatt commented at 9:40 PM on October 23, 2016: contributor
@rebroad this will not change propagation speeds between reasonably up-to-date nodes, and fixes several issues. @mrbandrews found some issues with the tests...will get this rebased once they are fixed.
- TheBlueMatt force-pushed on Oct 26, 2016
-
TheBlueMatt commented at 9:15 PM on October 26, 2016: contributor
Rebased and replaced my broken test update with one from @mrbandrews.
-
sipa commented at 10:27 PM on November 7, 2016: member
Needs rebase.
-
[qa] Make comptool push blocks instead of relying on inv-fetch d768f151f6
-
[qa] Respond to getheaders and do not assume a getdata on inv 3451203b5c
-
Remove block-request logic from INV message processing 037159cebf
- TheBlueMatt force-pushed on Nov 7, 2016
-
TheBlueMatt commented at 10:43 PM on November 7, 2016: contributor
Rebased.
-
sipa commented at 2:32 AM on November 8, 2016: member
utACK 037159cebf1eae4445050cec029986514ed4e9e2
- laanwj merged this on Nov 21, 2016
- laanwj closed this on Nov 21, 2016
- laanwj referenced this in commit 0c577f2638 on Nov 21, 2016
-
morcos commented at 8:06 PM on November 21, 2016: member
posthumous utACK Thanks!!
- laanwj cross-referenced this on May 7, 2017 from issue removed unused code in INV message by Greg-Griffith
- codablock referenced this in commit e5cc7d0eb4 on Jan 15, 2018
- gladcow cross-referenced this on Mar 1, 2018 from issue Backport compact blocks functionality from bitcoin by gladcow
- gladcow referenced this in commit 064f8dc0aa on Mar 5, 2018
- gladcow referenced this in commit b3c281775f on Mar 13, 2018
- gladcow referenced this in commit 597da4e24d on Mar 14, 2018
- gladcow referenced this in commit 30ad74bb6d on Mar 15, 2018
- gladcow referenced this in commit efec14ba8a on Mar 15, 2018
- gladcow referenced this in commit 961978146b on Mar 15, 2018
- gladcow referenced this in commit 332385ce33 on Mar 15, 2018
- gladcow referenced this in commit f5f2eb076a on Mar 24, 2018
- gladcow referenced this in commit 8fdfa6e414 on Apr 4, 2018
- UdjinM6 referenced this in commit bc45a2f87a on Apr 11, 2018
- andvgal referenced this in commit 78bf9c1fcf on Jan 6, 2019
- andvgal referenced this in commit fd5c50bc2b on Jan 6, 2019
- CryptoCentric referenced this in commit 3fd59437d8 on Feb 24, 2019
- CryptoCentric referenced this in commit dd3fd51204 on Feb 28, 2019
- bitcoin locked this on Sep 8, 2021
