A lot of noise just to get one less GetArg call from util.cpp. But explicit is better than implicit, specially if we ever want to decouple the util building package from global variables, or at least separate them in single file for each building module.
Globals: Decouple GetConfigFile and ReadConfigFile from global mapArgs #8856
pull jtimon wants to merge 1 commits into bitcoin:master from jtimon:0.13-globals-utils-configfile changing 6 files +12 −11-
jtimon commented at 6:33 AM on October 1, 2016: contributor
-
Globals: Decouple GetConfigFile and ReadConfigFile from global mapArgs 3450c18a12
- fanquake added the label Refactoring on Oct 1, 2016
-
laanwj commented at 5:36 PM on October 2, 2016: member
Yes, makes sense. Removing side effects is a good thing.
At some point we we need to make our own implementation of the config parser instead of
boost::options. This will be less hacky if we have a proper API instead of just slinging values into global maps. -
laanwj commented at 8:50 AM on October 3, 2016: member
-
MarcoFalke commented at 9:11 AM on October 3, 2016: member
utACK 3450c18
- laanwj merged this on Oct 3, 2016
- laanwj closed this on Oct 3, 2016
- laanwj referenced this in commit a7e5cbb209 on Oct 3, 2016
- str4d cross-referenced this on May 17, 2017 from issue mapArgs is modified by setgenerate RPC without locking by daira
- str4d cross-referenced this on May 19, 2017 from issue Misc upstream PRs by str4d
- codablock referenced this in commit 873e598d83 on Sep 19, 2017
- codablock referenced this in commit 14483e46f9 on Jan 12, 2018
- zkbot referenced this in commit f1aeaec471 on Mar 21, 2018
- MarcoFalke cross-referenced this on Mar 24, 2018 from issue Store the current config file at read time, and return it from GetConfigFile if set by Empact
- andvgal referenced this in commit 42e7b9bff0 on Jan 6, 2019
- zkbot referenced this in commit 4fc490c430 on Dec 4, 2019
- zkbot referenced this in commit 868c63f92d on Dec 4, 2019
- random-zebra cross-referenced this on Apr 19, 2021 from issue [Core] Network specific configuration sections by random-zebra
- furszy referenced this in commit 0255df35a6 on Apr 26, 2021
- bitcoin locked this on Sep 8, 2021
