[qa] fix nulldummy test #8841

1. 
   jl2012 commented at 4:23 PM on September 29, 2016: contributor

   Sorry that I just find a minor bug in the test. msg is used to indicate that the transaction should be rejected. However, before this fix, even if the tx was accepted with a non-empty msg, the test would still pass.

2. laanwj added the label Tests on Sep 29, 2016
3. MarcoFalke added the label Needs backport on Sep 29, 2016
4. MarcoFalke added this to the milestone 0.13.1 on Sep 29, 2016
5. in qa/rpc-tests/nulldummy.py:None in 8623ec06fc outdated

    118 | @@ -119,6 +119,9 @@ def tx_submit(self, node, tx, msg = ""):
    119 |              node.sendrawtransaction(bytes_to_hex_str(tx.serialize_with_witness()), True)
    120 |          except JSONRPCException as exp:
    121 |              assert_equal(exp.error["message"], msg)
    122 | +        else:
    123 | +            if (msg):
    124 | +                assert(False)
   

   ---

   ---

   

   MarcoFalke commented at 5:30 PM on September 29, 2016:

   To print the message on failure, what about something like

   assert_equal('', msg)
   

   ---

   

   jl2012 commented at 5:35 PM on September 29, 2016:

   revise as suggested. Thanks

6. jl2012 force-pushed on Sep 29, 2016
7. jl2012 cross-referenced this on Sep 29, 2016 from issue p2p-compactblocks.py fails randomly by jl2012
8. Fix nulldummy.py test 46a4774d2b
9. jl2012 force-pushed on Sep 29, 2016
10. 
    MarcoFalke commented at 6:53 PM on September 29, 2016: member

    utACK 46a4774d2bb9cc863e43507212ef989fa10d56d4

11. laanwj merged this on Sep 30, 2016
12. laanwj closed this on Sep 30, 2016

    ---

13. laanwj referenced this in commit 83998b52d0 on Sep 30, 2016
14. MarcoFalke referenced this in commit 3e4abb5025 on Oct 3, 2016
15. MarcoFalke removed the label Needs backport on Oct 13, 2016
16. codablock referenced this in commit 4bb0cdf400 on Jan 30, 2018
17. andvgal referenced this in commit 204cbf8635 on Jan 6, 2019
18. CryptoCentric referenced this in commit 8ba834ea6f on Feb 28, 2019
19. CryptoCentric referenced this in commit 48dac27042 on Mar 2, 2019
20. bitcoin locked this on Sep 8, 2021

Contributors

jl2012MarcoFalke

Milestone
0.13.1