bitcoin-util-test.py should fail if the output file is empty #8836

1. 
   jnewbery commented at 2:22 PM on September 29, 2016: member

   If the output_cmp file is empty, then bitcoin-util-test.py will pass the test without comparing its output to the expected output. This PR makes the test case fail if the output_cmp file is empty.

   This PR also fixes the txcreate2.json file so it's no longer empty (and is therefore actually testing something!)

2. bitcoin-util-test.py should fail if the output file is empty da94697708
3. jnewbery cross-referenced this on Sep 29, 2016 from issue Add bitcoin-tx JSON tests by jnewbery
4. laanwj added the label Tests on Sep 29, 2016
5. 
   MarcoFalke commented at 3:52 PM on September 29, 2016: member

   utACK da9469770847df56e67e629986129a087b5bd7a5

6. 
   laanwj commented at 4:10 PM on September 29, 2016: member

   utACK https://github.com/bitcoin/bitcoin/pull/8836/commits/da9469770847df56e67e629986129a087b5bd7a5

7. MarcoFalke added the label Needs backport on Sep 29, 2016
8. MarcoFalke added this to the milestone 0.13.1 on Sep 29, 2016
9. laanwj merged this on Sep 30, 2016
10. laanwj closed this on Sep 30, 2016

    ---

11. laanwj referenced this in commit 90adfabd5d on Sep 30, 2016
12. jnewbery deleted the branch on Sep 30, 2016
13. MarcoFalke referenced this in commit eb18cc1272 on Oct 3, 2016
14. MarcoFalke removed the label Needs backport on Oct 13, 2016
15. codablock referenced this in commit 5f67cee1ef on Sep 19, 2017
16. codablock referenced this in commit 972a44b707 on Jan 12, 2018
17. dagurval cross-referenced this on Apr 27, 2018 from issue bitcoin-tx JSON tests + test util improvements by dagurval
18. lateminer referenced this in commit 7f51c400d2 on Nov 11, 2018
19. andvgal referenced this in commit 8f44c229b8 on Jan 6, 2019
20. str4d cross-referenced this on Oct 28, 2020 from issue bitcoin-util-test.py backports by str4d
21. zkbot referenced this in commit 44f5ef7c9d on Nov 9, 2020
22. zkbot referenced this in commit bd5ff7c889 on Nov 9, 2020
23. bitcoin locked this on Sep 8, 2021

Contributors

jnewberyMarcoFalkelaanwj

Milestone
0.13.1