Minimal fix to slow prevector tests as stopgap measure #8671

pull JeremyRubin wants to merge 1 commits into bitcoin:master from JeremyRubin:simple_faster_tests changing 1 files +43 −19

JeremyRubin commented at 8:38 PM on September 6, 2016: contributor

Tests are really slow because of BOOST_CHECK doing a lot of unnecessary things in wine, BOOST_CHECK can't just be ripped out because some people rely on certain features for there dev process.

In lieu of a more permanent fix, this PR minimally modifies PrevectorTests to use a local check. To make sure this local check isn't useless, it gets the seeds from the insecure random to allow tests to be repeated.

This should be an easy to merge PR; discussion about generally improving the unit test performance/framework beyond this can go here: #8670
Minimal fix to slow prevector tests as stopgap measure f71d4a3786
JeremyRubin cross-referenced this on Sep 6, 2016 from issue Make tests much faster by replacing BOOST_CHECK with FAST_CHECK by JeremyRubin
JeremyRubin commented at 8:49 PM on September 6, 2016: contributor

Benchmarks

On my local machine on a 32-bit win build running just PrevectorTests goes from taking 4 minutes + 24 seconds to 1.2 seconds with this patch.
sipa commented at 8:56 PM on September 6, 2016: member

Concept ACK
TheBlueMatt commented at 9:43 PM on September 6, 2016: contributor

utACK
fanquake added the label Tests on Sep 7, 2016
dcousens commented at 2:55 AM on September 7, 2016: contributor

concept ACk
JeremyRubin commented at 3:35 AM on September 7, 2016: contributor

Travis Benchmarks

Comparing this build to the head build time for make check to run:

Job 2 (i686-w64-mingw32)

678s→337s

data:

https://travis-ci.org/bitcoin/bitcoin/jobs/157997974 https://travis-ci.org/bitcoin/bitcoin/jobs/157884494

Job 4 (x86_64-w64-mingw32)

529s→196s

data:

https://travis-ci.org/bitcoin/bitcoin/jobs/157997976 https://travis-ci.org/bitcoin/bitcoin/jobs/157884498
jonasschnelli commented at 6:21 AM on September 7, 2016: contributor

utACK https://github.com/bitcoin/bitcoin/pull/8671/commits/f71d4a3786611d564e4c239099501daee989b170
MarcoFalke commented at 6:32 PM on September 7, 2016: member

Thanks! utACK f71d4a3786611d564e4c239099501daee989b170
MarcoFalke merged this on Sep 8, 2016
MarcoFalke closed this on Sep 8, 2016
MarcoFalke referenced this in commit ddc308068d on Sep 8, 2016
codablock cross-referenced this on Jan 9, 2018 from issue Automatically build and push docker image to docker.io/dashpay/dashd-develop by codablock
random-zebra cross-referenced this on Jan 19, 2021 from issue [Core] Prevector Optimizations 2 by random-zebra
furszy referenced this in commit 07b88da888 on Jan 25, 2021
str4d cross-referenced this on Feb 17, 2021 from issue Fix prevector bugs by nuttycom
nuttycom cross-referenced this on Feb 17, 2021 from issue Fix prevector bugs. by nuttycom
zkbot referenced this in commit cd00fb08d5 on Feb 17, 2021
bitcoin locked this on Sep 8, 2021