Fix SIGHASH_SINGLE bug in test_framework SignatureHash #8667

pull jl2012 wants to merge 1 commits into bitcoin:master from jl2012:patch-16 changing 1 files +1 −1
  1. jl2012 commented at 4:50 PM on September 5, 2016: contributor

    The value for "other" inputs should be -1 (0xffffffffffffffff) instead of 0

  2. Fix SIGHASH_SINGLE bug in test_framework SignatureHash
    The value for "other" inputs should be -1 (0xffffffffffffffff) instead of 0
    2f2548d5e0
  3. sipa commented at 4:51 PM on September 5, 2016: member

    Any unit tests in which this is exposed?

  4. jl2012 commented at 5:14 PM on September 5, 2016: contributor

    @sipa: yes, the Bare_137_CHECKSIG_random_flag in #8654

  5. fanquake added the label Tests on Sep 5, 2016
  6. sdaftuar commented at 12:02 AM on September 6, 2016: member

    utACK

  7. jl2012 cross-referenced this on Sep 6, 2016 from issue [WIP] Reuse sighash computations across evaluation by jl2012
  8. laanwj commented at 1:10 PM on September 6, 2016: member

    Shouldn't this affect passing/non-passing of the test? Or is this part of the framework unused?

  9. sipa commented at 1:16 PM on September 6, 2016: member

    @laanwj It is unused until the introduction of the test in #8654 (which needs to pass a -1 explicitly for now).

  10. Christewart commented at 2:16 PM on September 6, 2016: contributor

    utACK

  11. fanquake commented at 3:16 AM on September 9, 2016: member

    utACK 2f2548d

  12. MarcoFalke merged this on Sep 9, 2016
  13. MarcoFalke closed this on Sep 9, 2016

  14. MarcoFalke referenced this in commit 2a0836f6d5 on Sep 9, 2016
  15. luke-jr referenced this in commit 6b07362b37 on Sep 21, 2016
  16. codablock referenced this in commit 5cdedb2d96 on Sep 19, 2017
  17. codablock referenced this in commit ce520f1614 on Jan 9, 2018
  18. codablock referenced this in commit 85c0aabc11 on Jan 9, 2018
  19. andvgal referenced this in commit c0cae10dfd on Jan 6, 2019
  20. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC