[Wallet] refactor CWallet/CWalletDB/CDB #8574

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2016/08/bdb_abstraction_2 changing 5 files +237 −152
  1. jonasschnelli commented at 8:15 AM on August 24, 2016: contributor

    Try to hide CDB/bitdb behind CWalletDB. This is a first chunk of changes (does not cover everything to avoid an oversized PR).

    Prepare for full wallet database abstraction which is required for smooth migration to a different wallet database format (must be supported in parallel).

    We probably shouldn't stay forever with Berkley-DB4.8.

  2. jonasschnelli added the label Refactoring on Aug 24, 2016
  3. jonasschnelli added the label Wallet on Aug 24, 2016
  4. pstratem commented at 8:35 AM on August 24, 2016: contributor

    Concept ACK

  5. MarcoFalke commented at 8:36 AM on August 24, 2016: member

    I haven't looked at this closely but if this is code movement as well as refactoring, I'd prefer two commits (or better: two pulls)

  6. jonasschnelli commented at 8:37 AM on August 24, 2016: contributor

    Pure moving was not possible. This PR does separate "mixed" code into parts covered by the wallet logic and other parts covered by the database storage logic.

  7. dcousens commented at 1:59 AM on August 25, 2016: contributor

    concept ACK

  8. fanquake commented at 3:20 AM on September 9, 2016: member

    This needs a rebase.

  9. jmcorgan commented at 7:07 PM on December 3, 2016: contributor

    I have a rebased version of this at jmcorgan/2016/12/bdb_abstraction_2. @jonasschnelli Feel free to clone this and push to update this PR.

  10. [Wallet] refactor CWallet/CWalletDB/CDB
    Try to hide CDB/bitdb behinde CWalletDB.
Prepare for full wallet database abstraction.
    7184e25c80
  11. jonasschnelli force-pushed on Mar 6, 2017
  12. jonasschnelli commented at 10:33 AM on March 6, 2017: contributor

    Rebased. Again, this moves some of the direct BDB interaction from walletdb to the BDB abstraction class CDBEnv. This is a stepping stone for a clean wallet database abstraction.

  14. laanwj merged this on Mar 6, 2017
  15. laanwj closed this on Mar 6, 2017
  16. laanwj referenced this in commit 8a3b07529d on Mar 6, 2017
  17. paveljanik cross-referenced this on Mar 6, 2017 from issue Wshadow: various gcc fixes by paveljanik
  18. ryanofsky cross-referenced this on Jun 6, 2017 from issue Basic multiwallet support by luke-jr
  19. PastaPastaPasta referenced this in commit 9d758a1322 on Dec 30, 2018
  20. PastaPastaPasta referenced this in commit 4de35d6439 on Dec 30, 2018
  21. PastaPastaPasta referenced this in commit 833fc27fa4 on Dec 30, 2018
  22. PastaPastaPasta referenced this in commit 98ad304ada on Dec 30, 2018
  23. PastaPastaPasta referenced this in commit 19f3a8c13c on Dec 30, 2018
  24. PastaPastaPasta referenced this in commit 3a5829d24b on Dec 31, 2018
  25. PastaPastaPasta referenced this in commit d5b21ea159 on Dec 31, 2018
  26. PastaPastaPasta referenced this in commit ba28b97375 on Dec 31, 2018
  27. PastaPastaPasta referenced this in commit c87f0b5111 on Dec 31, 2018
  28. PastaPastaPasta referenced this in commit 2457761d16 on Dec 31, 2018
  29. PastaPastaPasta referenced this in commit f30e18b9b7 on Dec 31, 2018
  30. PastaPastaPasta referenced this in commit a2cd2d2906 on Dec 31, 2018
  31. PastaPastaPasta referenced this in commit 21ebae0044 on Jan 2, 2019
  32. PastaPastaPasta referenced this in commit af0663d063 on Jan 2, 2019
  33. PastaPastaPasta referenced this in commit d945acca22 on Jan 2, 2019
  34. PastaPastaPasta referenced this in commit e3534c6ed5 on Jan 2, 2019
  35. PastaPastaPasta referenced this in commit 3bd22e3bcb on Jan 3, 2019
  36. PastaPastaPasta referenced this in commit 3b16cc4964 on Jan 3, 2019
  37. PastaPastaPasta referenced this in commit c3d82e552a on Jan 21, 2019
  38. PastaPastaPasta referenced this in commit a2f3858375 on Jan 21, 2019
  39. PastaPastaPasta referenced this in commit 1dac7d8967 on Jan 27, 2019
  40. PastaPastaPasta referenced this in commit 7f403c56a1 on Jan 27, 2019
  41. PastaPastaPasta referenced this in commit 05fdaed953 on Jan 29, 2019
  42. PastaPastaPasta referenced this in commit 889726aa55 on Jan 29, 2019
  43. PastaPastaPasta referenced this in commit d939abcd24 on Feb 5, 2019
  44. PastaPastaPasta referenced this in commit 29bbfc58fe on Feb 5, 2019
  45. Warrows referenced this in commit 820e9204e2 on Oct 14, 2019
  46. Warrows cross-referenced this on Nov 22, 2019 from issue [Utils] Fix windows utf8 paths by Warrows
  47. Warrows referenced this in commit 8172bd149d on Nov 23, 2019
  48. furszy cross-referenced this on Oct 26, 2020 from issue [Wallet][DB] Back ports up to the CWallet/CWalletDB/CDB refactor. by furszy
  49. random-zebra referenced this in commit 46fad30bbb on Nov 15, 2020
  50. bitcoin locked this on Sep 8, 2021
Contributors
jonasschnellipstratemMarcoFalkedcousensfanquakejmcorganlaanwj
Labels
RefactoringWallet
Linked (view graph)
#8694 Basic multiwallet support#9911 Wshadow: various gcc fixes
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC