Trivial: pass Consensus::Params& instead of CChainParams& in ContextualCheckBlock #8413

pull jtimon wants to merge 1 commits into bitcoin:master from jtimon:0.13-consensus-last-params changing 2 files +5 −5

jtimon commented at 9:49 PM on July 27, 2016: contributor

Pre-witness my plan was to get rid of ContextualCheckBlock and move its check to ConnectBlock/Consensus::VerifyTx, so this was not necessary.

This should be the last existing consensus function that needs to get Consensus::Params instead of ChainParams or call Params() from inside.
Trivial: pass Consensus::Params& instead of CChainParams& in ContextualCheckBlock c8664eeac7
jtimon force-pushed on Jul 27, 2016
jtimon commented at 9:58 PM on July 27, 2016: contributor

Sorry, contained an old TODO that wasn't true. Updated. Ping @NicolasDorier @dcousens
jtimon cross-referenced this on Jul 27, 2016 from issue Globals: TODO: Experiment: Kill "Params()" by jtimon
dcousens commented at 1:24 AM on July 28, 2016: contributor

utACK c8664ee
NicolasDorier commented at 2:27 AM on July 28, 2016: contributor

utACK c8664eeac75fb87282dc69049cfa23d583742629
jonasschnelli added the label Refactoring on Jul 28, 2016
sipa commented at 7:45 PM on July 29, 2016: member

utACK c8664eeac75fb87282dc69049cfa23d583742629
paveljanik commented at 7:44 PM on July 30, 2016: contributor

utACK https://github.com/bitcoin/bitcoin/pull/8413/commits/c8664eeac75fb87282dc69049cfa23d583742629
btcdrak commented at 10:29 PM on July 31, 2016: contributor

utACK c8664ee
sipa merged this on Jul 31, 2016
sipa closed this on Jul 31, 2016
sipa referenced this in commit 8ea7d31e38 on Jul 31, 2016
codablock referenced this in commit 449b28ca0e on Sep 19, 2017
codablock referenced this in commit 1ac348176b on Dec 29, 2017
codablock referenced this in commit aa6c37919b on Jan 8, 2018
andvgal referenced this in commit 2280d1db66 on Jan 6, 2019
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7829 Globals: TODO: Experiment: Kill "Params()"