mining: Rename `-blockmaxcost` to `-blockmaxweight` #8354

1. 
   laanwj commented at 6:10 AM on July 18, 2016: member

   As discussed in the 2016-07-14 meeting, http://www.erisian.com.au/meetbot/bitcoin-core-dev/2016/bitcoin-core-dev.2016-07-14-19.00.html

   Needs an analogous change to BIP141: https://github.com/bitcoin/bips/pull/420

2. laanwj added the label Mining on Jul 18, 2016
3. laanwj added this to the milestone 0.13.0 on Jul 18, 2016
4. laanwj cross-referenced this on Jul 18, 2016 from issue Mining-related fixups for 0.13.0 by sdaftuar
5. mining: Rename `-blockmaxcost` to `-blockmaxweight`

   As discussed in the 2016-07-14 meeting,
   http://www.erisian.com.au/meetbot/bitcoin-core-dev/2016/bitcoin-core-dev.2016-07-14-19.00.html

   bf70224d0e
6. laanwj force-pushed on Jul 18, 2016
7. 
   MarcoFalke commented at 7:13 AM on July 18, 2016: member

   ACK bf70224 (Haven't checked for proper replacement in all places but I imagine check-doc would catch that.)

8. 
   paveljanik commented at 7:29 AM on July 18, 2016: contributor

   src/rpc/blockchain.cpp: " "cost" : n (numeric) The block cost\n" src/rpc/mining.cpp: " "currentblockcost": nnn, (numeric) The last block cost\n" src/main.cpp: return state.DoS(100, error("ContextualCheckBlock(): cost limit failed"), REJECT_INVALID, "bad-blk-cost");

   etc.

9. 
   paveljanik commented at 7:34 AM on July 18, 2016: contributor

   Hmm, what about using the term "blockcost" instead?

10. 
    laanwj commented at 8:43 AM on July 18, 2016: member

    @paveljanik yes if you want to change all occurrences, also in variable names, then there is much more code impact.

11. 
    laanwj commented at 8:46 AM on July 18, 2016: member

    Bah, changing all occurences of 'cost' to 'weight' is a huge change. I'm also having second thoughts about it. Changing it just in user-facing messages is doable, but yes it also appears in the RPC API, in variable names, in tons of comments. And I suppose those all have to be changed for consistency.

12. laanwj closed this on Jul 18, 2016

    ---

13. laanwj referenced this in commit 8cef5bd58a on Jul 18, 2016
14. laanwj cross-referenced this on Jul 18, 2016 from issue mining: Improve `-blockmaxcost` help message by laanwj
15. sdaftuar cross-referenced this on Jul 18, 2016 from issue Rename "block cost" to "block weight" by sdaftuar
16. bitcoin locked this on Sep 8, 2021

Contributors

laanwjMarcoFalkepaveljanik

Milestone
0.13.0