Fix pkg-config issues for 0.13 #8314

1. 
   theuni commented at 6:39 PM on July 7, 2016: member

   For 0.13, I'd prefer to keep the requirements the same as before: All platforms require pkg-config except for Windows.

   For now, I believe I've fixed up the current issues and regressions. Fixes: #8228, replaces #8242.

   Post-0.13, I believe the consensus is to treat Windows like the others and require pkg-config across the board. We can drop all of the non-pkg-config paths, and simply AC_REQUIRE(PKG_PROG_PKG_CONFIG)

2. build: Fix Qt5PlatformSupport check without pkg-config

   The non-pkg-config case can't use pkg-config to check the version.
   
   Also, make sure that the check is properly guarded in the case of missing
   pkg-config macros.

   0c928cb13c
3. build: fix Windows builds without pkg-config

   - guard PKG_PROG_PKG_CONFIG with an m4_ifdef. If not building for windows,
     require it
   - add nops as necessary in case the ifdef reduces the if/then to nothing
   - AC_SUBST some missing _LIBS. These were split out over time, but not all were
     properly substituted. They continued to work if pkg-config is installed
     because it does the AC_SUBST itself

   b556beda26
4. MarcoFalke added this to the milestone 0.13.0 on Jul 7, 2016
5. MarcoFalke added the label Build system on Jul 7, 2016
6. 
   jonasschnelli commented at 6:52 AM on July 8, 2016: contributor

   Gitian was happy with this PR: https://bitcoin.jonasschnelli.ch/pulls/8314/

7. laanwj cross-referenced this on Jul 8, 2016 from issue gitian: Don't require sudo for Linux. by theuni
8. 
   laanwj commented at 1:07 PM on July 8, 2016: member

   Works for me - retried #8228 and get an error now, as expected:

   configure: error: PKG_PROG_PKG_CONFIG macro not found. Please install pkg-config and re-run autogen.sh.
   

9. laanwj merged this on Jul 8, 2016
10. laanwj closed this on Jul 8, 2016

    ---

11. laanwj referenced this in commit 67caef6730 on Jul 8, 2016
12. paveljanik cross-referenced this on Jul 30, 2016 from issue Check if the macro PKG_PROG_PKG_CONFIG was expanded. by paveljanik
13. codablock referenced this in commit ef8043b9c9 on Sep 19, 2017
14. schinzelh cross-referenced this on Oct 23, 2017 from issue [WIP] Update build system to Bitcoin 0.13.2 by schinzelh
15. str4d cross-referenced this on Dec 1, 2017 from issue Build system improvements by str4d
16. zkbot referenced this in commit 75604363cc on Dec 1, 2017
17. zkbot referenced this in commit 6aef4033a7 on Dec 1, 2017
18. zkbot referenced this in commit 83af270002 on Dec 15, 2017
19. codablock referenced this in commit 4d6c2d9894 on Dec 27, 2017
20. codablock referenced this in commit 1670472976 on Dec 28, 2017
21. kotodev referenced this in commit c8a979fc92 on Jan 25, 2018
22. renium9 referenced this in commit 23640da445 on Feb 6, 2018
23. sickpig cross-referenced this on Jun 21, 2018 from issue [PORT] Update build_qt.m4 by sickpig
24. andvgal referenced this in commit 303ab7162c on Jan 6, 2019
25. hebasto cross-referenced this on Dec 31, 2019 from issue build: Add ability to bypass pkg-config for Qt by hebasto
26. hebasto cross-referenced this on Mar 9, 2020 from issue build: Use pkg-config in BITCOIN_QT_CONFIGURE for all hosts including Windows by hebasto
27. fanquake referenced this in commit 265492723a on Jun 13, 2020
28. sidhujag referenced this in commit c8addbe7ea on Jun 13, 2020
29. xdustinface referenced this in commit e2d3235eb2 on Feb 17, 2021
30. gades referenced this in commit ac855be7fd on Jun 27, 2021
31. bitcoin locked this on Sep 8, 2021

Contributors

theunijonasschnellilaanwj

Milestone
0.13.0