Fix wallet locking locking #828

pull sipa wants to merge 3 commits into bitcoin:master from sipa:fixwalletlock changing 3 files +32 −20

sipa commented at 4:04 PM on February 11, 2012: member

Fixes some possible race conditions in ThreadCleanWalletPassphrase().
sipa commented at 5:06 PM on February 11, 2012: member
Added some extra fixes:
- Fix sign error in calculation of seconds to sleep
- Do not mix GetTime() (seconds) and Sleep() (milliseconds)
- Do not sleep forever if another thread already re-locked (should close #639)
- Do locking within critical section
TheBlueMatt commented at 7:14 PM on February 11, 2012: contributor

ACK
Macros for manual critical sections 88bc5f9485
Fix wallet locking locking b0529ffd95

Extra wallet locking fixes

* Fix sign error in calculation of seconds to sleep
* Do not mix GetTime() (seconds) and Sleep() (milliseconds)
* Do not sleep forever if walletlock() is called
* Do locking within critical section

aa625ed6ed

sipa referenced this in commit 711d5038f5 on Feb 16, 2012
sipa merged this on Feb 16, 2012
sipa closed this on Feb 16, 2012
sipa cross-referenced this on Feb 19, 2012 from issue Wallet does not relock on Win32 by TheBlueMatt
coblee referenced this in commit 94fd85c68a on Jul 17, 2012
destenson referenced this in commit 9745914c15 on Jun 26, 2016
ptschip referenced this in commit 524ab8d2ef on Dec 27, 2017
bitcoin locked this on Sep 8, 2021

Contributors

sipa

TheBlueMatt

Linked (view graph)

#571 Wallet does not relock on Win32 #639 Memory Leak in walletlock - Threads spawned and never killed