I'm happy to be wrong, but I can't see why this is necessary, especially when the mempool locks are all in place in subsequent functions?
remove unnecessary LOCK(cs_main) in getrawpmempool #8244
pull dcousens wants to merge 1 commits into bitcoin:master from dcousens:patch-1 changing 1 files +0 −2-
dcousens commented at 2:45 AM on June 23, 2016: contributor
-
remove unnecessary LOCK(cs_main) 27f8126ff3
- dcousens renamed this:
remove unnecessary LOCK(cs_main)
remove unnecessary LOCK(cs_main) in getrawpmempool
on Jun 23, 2016 -
laanwj commented at 7:09 AM on June 23, 2016: member
I think you are right. utACK https://github.com/bitcoin/bitcoin/pull/8244/commits/27f8126ff37ec590c266adc6228d216857606536
- laanwj added the label RPC/REST/ZMQ on Jun 23, 2016
-
paveljanik commented at 11:13 AM on June 23, 2016: contributor
-
pstratem commented at 11:34 PM on June 23, 2016: contributor
utACK 27f8126ff37ec590c266adc6228d216857606536
-
fanquake commented at 1:19 AM on June 24, 2016: member
utACK 27f8126
-
sipa commented at 2:53 PM on June 24, 2016: member
utACK 27f8126ff37ec590c266adc6228d216857606536
- laanwj merged this on Jun 25, 2016
- laanwj closed this on Jun 25, 2016
- laanwj referenced this in commit 1922e5a654 on Jun 25, 2016
- dcousens deleted the branch on Jun 26, 2016
- MarcoFalke cross-referenced this on Jan 26, 2018 from issue rpc: Add back missing cs_main lock in getrawmempool by MarcoFalke
- LarryRuane cross-referenced this on Feb 20, 2021 from issue Bitcoin 0.13 locking PRs by LarryRuane
- zkbot referenced this in commit d95a957841 on Apr 1, 2021
- zkbot referenced this in commit 2d3b58c993 on Apr 1, 2021
- bitcoin locked this on Sep 8, 2021
