[qa] fundrawtransaction: Fix race, assert amounts #8201

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:Mf1606-qaFundraw changing 3 files +22 −12

MarcoFalke commented at 5:50 PM on June 13, 2016: member
Alternative to #8199 and #8200:
- Make sure to sync the nodes when required
- Make sure the fee has the correct amount without doing an assert_equal
MarcoFalke added the label Tests on Jun 13, 2016
MarcoFalke force-pushed on Jun 13, 2016
[qa] util: Move check_fee_amount out of wallet.py fa26c420bf
[qa] fundrawtransaction: Fix race, assert amounts fae1d063fc
MarcoFalke force-pushed on Jun 13, 2016
sipa commented at 9:33 PM on June 13, 2016: member

Tested ACK fae1d063fc8a54067a8527d249d8801a00feef03 (solves #8199 for me).
laanwj commented at 6:32 AM on June 14, 2016: member

Works for me - when I run fundrawtransaction.py in a loop without this patch it fails once in a while with InsufficientFunds, I've now been running with this patch for quite some time and haven't got one error.

ACK fae1d06
laanwj merged this on Jun 14, 2016
laanwj closed this on Jun 14, 2016
laanwj referenced this in commit 36b74002f8 on Jun 14, 2016
jonasschnelli cross-referenced this on Jun 14, 2016 from issue [Tests] Fix fundrawtransaction feerate test by jonasschnelli
MarcoFalke deleted the branch on Jun 14, 2016

in qa/rpc-tests/fundrawtransaction.py:None in fae1d063fc

 692 | -        assert_equal(result['fee']*2, result2['fee'])
 693 | -        assert_equal(result['fee']*10, result3['fee'])
 694 | +        result_fee_rate = result['fee'] * 1000 / count_bytes(result['hex'])
 695 | +        assert_fee_amount(result2['fee'], count_bytes(result2['hex']), 2 * result_fee_rate)
 696 | +        assert_fee_amount(result3['fee'], count_bytes(result3['hex']), 10 * result_fee_rate)
 697 |

MarcoFalke commented at 11:45 AM on June 14, 2016:

fun fact: result_fee_rate != min_relay_tx_fee, even though it should. I should look into this to see if we can do any better.

codablock referenced this in commit cdd9148e9a on Sep 16, 2017
codablock referenced this in commit ed10cabc45 on Sep 19, 2017
codablock referenced this in commit 2e51d82735 on Dec 22, 2017
dagurval cross-referenced this on Feb 1, 2018 from issue fundrawtransaction cherries by dagurval
andvgal referenced this in commit 982dc921a3 on Jan 6, 2019
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8199 Avoid test bug introduced in #7967 #8200 [Tests] Fix fundrawtransaction feerate test