Alternative to #8112.
Use std::atomic for fRequestShutdown and fReopenDebugLog #8123
pull sipa wants to merge 2 commits into bitcoin:master from sipa:notsigbutatomic changing 3 files +4 −5-
sipa commented at 1:40 PM on May 30, 2016: member
- sipa cross-referenced this on May 30, 2016 from issue Include signal.h for sig_atomic_t in WIN32 by sipa
-
laanwj commented at 12:53 PM on May 31, 2016: member
Nice, yes I think this is a much better idea as the flags (well, fRequestShutdown, and we may want some non-signal reopen-debuglog trigger as well at some point) can be set from non-signal context as well.
utACK https://github.com/bitcoin/bitcoin/pull/8123/commits/ddd2c09e55430094ca87bb4930db093558dae6c7
-
16cf85fa2c
Revert "Include signal.h for sig_atomic_t in WIN32"
This reverts commit 88f14b999cb70f6c556633f2889e698a05305158.
-
Use std::atomic for fRequestShutdown and fReopenDebugLog a886dbf8e7
- sipa force-pushed on Jun 1, 2016
-
sipa commented at 5:19 PM on June 1, 2016: member
Oops, accidentally merged the alternative version. Updated this one to first revert the other...
- sipa merged this on Jun 1, 2016
- sipa closed this on Jun 1, 2016
- sipa referenced this in commit 2e0a99037d on Jun 1, 2016
- bitcartel cross-referenced this on Oct 25, 2016 from issue Upstream 8123 race condition by bitcartel
- zkbot referenced this in commit 11ce636a9d on Oct 25, 2016
- dagurval cross-referenced this on Apr 23, 2017 from issue Util ports by dagurval
- codablock referenced this in commit aaeff61cd4 on Sep 16, 2017
- codablock referenced this in commit 2c5b5a9989 on Sep 19, 2017
- codablock referenced this in commit bf069fb1bd on Dec 22, 2017
- andvgal referenced this in commit b1fef0f6cd on Jan 6, 2019
- bitcoin locked this on Sep 8, 2021
Labels