[qa] test_framework: Append portseed to tmpdir #8098

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1605-qatmpdir changing 1 files +2 −0
  1. MarcoFalke commented at 6:11 PM on May 24, 2016: member

    This makes it possible to specify a tmpdir while running tests in parallel.

  2. [qa] test_framework: Append portseed to tmpdir
    This makes it possible to specify a tmpdir while running tests in
parallel
    fa57b0c5ef
  3. MarcoFalke assigned MarcoFalke on May 24, 2016
  4. MarcoFalke cross-referenced this on May 24, 2016 from issue Test framework: only cleanup on successful test runs by sdaftuar
  5. sdaftuar commented at 9:59 AM on May 25, 2016: member

    How about a '.' in the name to separate dirname and port_seed, rather than a '/' for a new directory? Seems like tab-completion would work better that way.

  6. MarcoFalke commented at 3:44 PM on May 26, 2016: member

    @sdaftuar Can you explain how this helps tab-completion? I fail to see the difference in the '.' vs '/'.

    Also, this would mean to adjust the --tmpdir help to help="Path prefix for datadirs. (portseed is appended to the prefix)".

  7. sdaftuar commented at 4:35 PM on May 26, 2016: member

    @MarcoFalke Ah I hadn't thought about the --tmpdir argument requiring us to use space inside that directory tree, that's a fair point. I was just thinking that I have to press [tab] one extra time to tab-complete to a subdirectory, maybe that's unique to my shell/environment, but not a big deal.

    ACK

  8. sipa commented at 10:29 PM on May 26, 2016: member

    Concept ACK

  9. MarcoFalke merged this on May 27, 2016
  10. MarcoFalke closed this on May 27, 2016
  11. MarcoFalke referenced this in commit 06bd4f637f on May 27, 2016
  12. MarcoFalke deleted the branch on May 27, 2016
  13. sdaftuar cross-referenced this on Sep 2, 2016 from issue [qa] Cleanup doesn't get top level directory by sdaftuar
  14. codablock referenced this in commit b0ebd6a917 on Sep 16, 2017
  15. codablock referenced this in commit 0be90f350f on Sep 19, 2017
  16. codablock referenced this in commit 7db5be442a on Dec 21, 2017
  17. dagurval cross-referenced this on Feb 1, 2018 from issue QA cherries by dagurval
  18. andvgal referenced this in commit 656bcc4c9c on Jan 6, 2019
  19. str4d cross-referenced this on Nov 21, 2020 from issue Backport migration from rpc-tests.sh to rpc-tests.py by str4d
  20. zkbot referenced this in commit 025bd44543 on Nov 21, 2020
  21. zkbot referenced this in commit 7a0a268054 on Dec 2, 2020
  22. zkbot referenced this in commit c8896f9907 on Dec 2, 2020
  23. bitcoin locked this on Sep 8, 2021
Contributors
MarcoFalkesdaftuarsipa
Labels
Tests
Linked (view graph)
#8095 Test framework: only cleanup on successful test runs#8647 [qa] Cleanup doesn't get top level directory
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:55 UTC