Consensus: Decouple from chainparams.o and timedata.o #8077

pull jtimon wants to merge 1 commits into bitcoin:master from jtimon:0.12-consensus-chainparams changing 2 files +16 −17

jtimon commented at 12:46 PM on May 20, 2016: contributor
Do it for the consensus-critical functions:
- CheckBlockHeader
- CheckBlock
- ContextualCheckBlockHeader
Part of #7829. Competing with #7985 and #7947.

Rationale: if these functions are to be moved to the consensus module/package, they need to stop depending on chainparams.o and timedata.o from the server package. Somewhat analogous to #7459.
jtimon cross-referenced this on May 20, 2016 from issue [Consensus] Add nAdjustedTime parameter to CheckBlock and CheckBlockHeader. by pstratem

Consensus: Decouple from chainparams.o and timedata.o

Do it for the consensus-critical functions:

- CheckBlockHeader
- CheckBlock
- ContextualCheckBlockHeader

ee9f4a5b15

jtimon force-pushed on May 20, 2016
laanwj added the label Refactoring on May 20, 2016
dcousens commented at 7:08 AM on May 21, 2016: contributor

utACK ee9f4a5
laanwj commented at 2:44 PM on May 21, 2016: member

ut/Concept ACK https://github.com/bitcoin/bitcoin/commit/ee9f4a5b1505113eae0fe8d70fd0414bd5bce0ff
arowser commented at 8:43 AM on May 25, 2016: contributor

Can one of the admins verify this patch?
afk11 commented at 3:55 AM on May 28, 2016: contributor

utACK
sipa merged this on Jun 1, 2016
sipa closed this on Jun 1, 2016
sipa referenced this in commit 715e9fd745 on Jun 1, 2016
jtimon cross-referenced this on Jun 1, 2016 from issue Global params cleanup by hmel
jtimon cross-referenced this on Jul 18, 2016 from issue Globals: TODO: Experiment: Kill "Params()" by jtimon
codablock referenced this in commit 16993dc79f on Sep 16, 2017
codablock referenced this in commit 91300b693a on Sep 19, 2017
codablock referenced this in commit fefd0ace3e on Dec 22, 2017
andvgal referenced this in commit 6e519f8c02 on Jan 6, 2019
bitcoin locked this on Sep 8, 2021

Contributors

Labels