VerifyDB: don't check blocks that have been pruned #8076

pull sdaftuar wants to merge 1 commits into bitcoin:master from sdaftuar:pruning-checkblocks changing 2 files +7 −2
  1. sdaftuar commented at 10:11 AM on May 20, 2016: member

    If a pruning node ends up in a state where it has very few blocks on disk, then a node could fail to start up in VerifyDB. This pull changes the behavior for pruning nodes, so that we will just not bother trying to check blocks that have been pruned.

    I don't expect this edge case to be triggered much in practice currently; this is a preparatory commit for segwit (to deal with the case of pruning nodes that upgrade after segwit activation). @sipa

  2. sipa commented at 10:20 AM on May 20, 2016: member

    utACK b88515167cc2a5da7dc11f66c58404cc06c92838

  3. MarcoFalke commented at 12:47 PM on May 20, 2016: member

    utACK b885151

  4. laanwj added the label UTXO Db and Indexes on May 20, 2016
  5. gmaxwell commented at 2:56 PM on May 20, 2016: contributor

    utACK b88515167cc2a5da7dc11f66c58404cc06c92838 but this could also log when it runs out of data (might avoid a future bug where it hits that branch immediately and ends up checking nothing).

  6. jonasschnelli commented at 2:57 PM on May 20, 2016: contributor

    utACK b88515167cc2a5da7dc11f66c58404cc06c92838

  7. fanquake commented at 7:11 AM on May 21, 2016: member

    utACK b885151

  8. MarcoFalke cross-referenced this on May 22, 2016 from issue Fix RewindBlockIndex for pruning by sdaftuar
  9. VerifyDB: don't check blocks that have been pruned bd477f4e8b
  10. sdaftuar force-pushed on May 22, 2016
  11. sdaftuar commented at 1:16 PM on May 22, 2016: member

    Added logging for when it runs out of data, as @gmaxwell suggested.

  12. dcousens commented at 2:39 AM on May 23, 2016: contributor

    utACK bd477f4

  13. sipa merged this on May 25, 2016
  14. sipa closed this on May 25, 2016
  15. sipa referenced this in commit d72098038f on May 25, 2016
  16. sickpig referenced this in commit b7430bc0d3 on Feb 17, 2017
  17. sickpig cross-referenced this on Feb 17, 2017 from issue Port misc pruning stuff from core by sickpig
  18. codablock referenced this in commit 4c1919f021 on Sep 16, 2017
  19. codablock referenced this in commit 24252b0701 on Sep 19, 2017
  20. codablock referenced this in commit c571a94906 on Dec 21, 2017
  21. bitcoin locked this on Sep 8, 2021
Contributors
sdaftuarsipaMarcoFalkegmaxwelljonasschnellifanquakedcousens
Labels
UTXO Db and Indexes
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:55 UTC